Merge pull request #5799 from IntersectMBO/koslambrou/golden-example-tx-each-era

Add example transaction golden test for each era

Author: koslambrou

eras/allegra/impl/CHANGELOG.md

@@ -17,7 +17,7 @@
 * Make `Test.Cardano.Ledger.Allegra.Imp.spec` accept `Proxy era`
 * In `Test.Cardano.Ledger.Allegra.Examples`:
   - Remove `mkAllegraBasedExampleTx`, `exampleAllegraBasedTxBody`, `exampleAllegraBasedShelleyTxBody`
-  - Add `exampleAllegraBasedTx`
+  - Add `exampleAllegraBasedTx`, `exampleAllegraTx`
 
 ## 1.9.0.0
 

eras/allegra/impl/cardano-ledger-allegra.cabal

@@ -11,7 +11,10 @@ description:
 
 category: Network
 build-type: Simple
-data-files: cddl/data/allegra.cddl
+data-files:
+  cddl/data/allegra.cddl
+  golden/*.cbor
+
 extra-source-files: CHANGELOG.md
 
 source-repository head

eras/allegra/impl/golden/tx.cbor

@@ -12,8 +12,10 @@ import Cardano.Ledger.Allegra.Core
 import Cardano.Ledger.Allegra.Scripts
 import Cardano.Ledger.MemoBytes (EqRaw)
 import Cardano.Ledger.Plutus (emptyCostModels)
+import Paths_cardano_ledger_allegra (getDataFileName)
 import Test.Cardano.Ledger.Allegra.Arbitrary ()
 import Test.Cardano.Ledger.Allegra.Binary.Annotator ()
+import Test.Cardano.Ledger.Allegra.Examples (exampleAllegraTx)
 import Test.Cardano.Ledger.Allegra.TreeDiff ()
 import Test.Cardano.Ledger.Common
 import Test.Cardano.Ledger.Shelley.Era
@@ -37,6 +39,10 @@ instance EraTest AllegraEra where
 
   accountsFromAccountsMap = shelleyAccountsFromAccountsMap
 
+  mkEraFullPath = getDataFileName
+
+  exampleTx = exampleAllegraTx
+
 instance ShelleyEraTest AllegraEra
 
 instance AllegraEraTest AllegraEra

eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Era.hs

@@ -8,6 +8,7 @@
 -- don't care, we are only interested in serialisation, not validation.
 module Test.Cardano.Ledger.Allegra.Examples (
   ledgerExamples,
+  exampleAllegraTx,
   exampleAllegraBasedTx,
 ) where
 
@@ -44,14 +45,14 @@ ledgerExamples =
     exampleCoin
     exampleAllegraTx
     NoGenesis
-  where
-    exampleAllegraTx :: Tx TopTx AllegraEra
-    exampleAllegraTx =
-      exampleAllegraBasedTx
-        & addShelleyBasedTopTxExampleFee
-        & addShelleyToBabbageExampleProposedPUpdates
-        & addShelleyToBabbageTxCerts
-        & addShelleyToConwayTxCerts
+
+exampleAllegraTx :: Tx TopTx AllegraEra
+exampleAllegraTx =
+  exampleAllegraBasedTx
+    & addShelleyBasedTopTxExampleFee
+    & addShelleyToBabbageExampleProposedPUpdates
+    & addShelleyToBabbageTxCerts
+    & addShelleyToConwayTxCerts
 
 -- Complete transaction which is compatible with any era starting with Allegra.
 -- This transaction forms the basis on which future era transactions will be

eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Examples.hs

@@ -2,7 +2,6 @@
 {-# LANGUAGE FlexibleContexts #-}
 {-# LANGUAGE TypeFamilies #-}
 {-# LANGUAGE TypeOperators #-}
-{-# OPTIONS_GHC -Wno-orphans #-}
 
 module Test.Cardano.Ledger.Allegra.Imp (spec) where
 

eras/allegra/impl/testlib/Test/Cardano/Ledger/Allegra/Imp.hs

@@ -51,7 +51,7 @@
 * `TranslationInstance` has a new field `tiPlutusPurpose`
 * In `Test.Cardano.Ledger.Alonzo.Examples`:
   - Remove `mkAlonzoBasedExampleTx`, `exampleAlonzoBasedShelleyTxBody`, `exampleAlonzoBasedTxBody`, `exampleRedeemer`
-  - Add `exampleAlonzoBasedTopTx`, `exampleAlonzoBasedTopTx`, `addAlonzoToConwayExampleReqSigners`
+  - Add `exampleAlonzoTx`, `exampleAlonzoBasedTopTx`, `exampleAlonzoBasedTopTx`, `addAlonzoToConwayExampleReqSigners`
 
 ## 1.15.0.0
 

eras/alonzo/impl/CHANGELOG.md

@@ -9,7 +9,7 @@ import qualified Test.Cardano.Ledger.Alonzo.Binary.CddlSpec as CddlSpec
 import qualified Test.Cardano.Ledger.Alonzo.Binary.CostModelsSpec as CostModelsSpec
 import qualified Test.Cardano.Ledger.Alonzo.Binary.TxWitsSpec as TxWitsSpec
 import qualified Test.Cardano.Ledger.Alonzo.BinarySpec as BinarySpec
-import qualified Test.Cardano.Ledger.Alonzo.GoldenSpec as Golden
+import qualified Test.Cardano.Ledger.Alonzo.GoldenSpec as GoldenSpec
 import qualified Test.Cardano.Ledger.Alonzo.GoldenTranslation as GoldenTranslation
 import qualified Test.Cardano.Ledger.Alonzo.Imp as Imp
 import qualified Test.Cardano.Ledger.Alonzo.Imp.TxInfoSpec as TxInfo
@@ -35,7 +35,7 @@ main =
     roundTripJsonEraSpec @AlonzoEra
     roundTripJsonShelleyEraSpec @AlonzoEra
     GoldenTranslation.tests
-    Golden.spec
+    GoldenSpec.spec
     describe "CostModels" $ do
       CostModelsSpec.spec @AlonzoEra
     describe "TxWits" $ do

eras/alonzo/test-suite/golden/tx.cbor eras/alonzo/impl/golden/tx.cboreras/alonzo/test-suite/golden/tx.cbor renamed to eras/alonzo/impl/golden/tx.cbor

@@ -10,7 +10,6 @@ import Cardano.Ledger.Core
 import Cardano.Ledger.MemoBytes (zipMemoRawType)
 import Cardano.Ledger.Plutus.Data (BinaryData, Data (..))
 import Test.Cardano.Ledger.Alonzo.Arbitrary ()
-import qualified Test.Cardano.Ledger.Alonzo.Binary.Golden as Golden
 import Test.Cardano.Ledger.Alonzo.Binary.RoundTrip (roundTripAlonzoCommonSpec)
 import Test.Cardano.Ledger.Alonzo.Binary.Twiddle ()
 import Test.Cardano.Ledger.Alonzo.TreeDiff ()
@@ -43,4 +42,3 @@ spec = do
     decoderEquivalenceEraSpec @AlonzoEra @(TxDats AlonzoEra)
     decoderEquivalenceEraSpec @AlonzoEra @(Redeemers AlonzoEra)
   Binary.txSizeSpec @AlonzoEra
-  Golden.spec @AlonzoEra