Deprecate goldenBudget and goldenEvalCekCatch

`goldenEvalCekCatchBudget` should be used instead

Author: SeungheonOh

plutus-benchmark/nofib/test/Spec.hs

@@ -70,7 +70,7 @@ testKnights = testGroup "knights"  -- Odd sizes call "error" because there are n
               , testCase "depth 100, 8x8" $ mkKnightsTest 100 8
               , runTestGhc
                     [ Tx.goldenPirReadable "knights10-4x4" knightsExample
-                    , Tx.goldenBudget "knights10-4x4" knightsExample
+                    , Tx.goldenEvalCekCatchBudget "knights10-4x4" knightsExample
                     ]
               ]
     where knightsExample = Knights.mkKnightsCode 10 4
@@ -91,7 +91,7 @@ testQueens = testGroup "queens"
                , testCase "Fc"    $ mkQueensTest 4 Queens.Fc
                , runTestGhc
                      [ Tx.goldenPirReadable "queens4-bt" queens4btExample
-                     , Tx.goldenBudget "queens4-bt" queens4btExample
+                     , Tx.goldenEvalCekCatchBudget "queens4-bt" queens4btExample
                      ]
                ]
              , testGroup "5x5"
@@ -102,7 +102,7 @@ testQueens = testGroup "queens"
                , testCase "Fc"    $ mkQueensTest 5 Queens.Fc
                , runTestGhc
                      [ Tx.goldenPirReadable "queens5-fc" queens5fcExample
-                     , Tx.goldenBudget "queens5-fc" queens5fcExample
+                     , Tx.goldenEvalCekCatchBudget "queens5-fc" queens5fcExample
                      ]
                ]
              ]

plutus-ledger-api/test-plugin/Spec/Data/Budget.hs

@@ -34,7 +34,6 @@ tests =
         ++ concatMap
           ( \(TestCase name code) ->
               [ goldenEvalCekCatchBudget name code
-              , goldenEvalCekCatch name [code]
               ]
           )
           testCases

plutus-tx-plugin/test/Strictness/Spec.hs

@@ -16,30 +16,30 @@ import PlutusTx.TH (compile)
 tests :: TestNested
 tests =
   testNested "Strictness" . pure $ testNestedGhc
-    [ goldenEvalCekCatch "lambda-default" [lambdaDefault `unsafeApplyCode` bot]
+    [ goldenEvalCekCatchBudget "lambda-default" [lambdaDefault `unsafeApplyCode` bot]
     , goldenPirReadable "lambda-default" lambdaDefault
     , goldenUPlcReadable "lambda-default" lambdaDefault
 
     -- FIXME: This should not crash, but it currently does.
-    , goldenEvalCekCatch "lambda-nonstrict" [lambdaNonStrict `unsafeApplyCode` bot]
+    , goldenEvalCekCatchBudget "lambda-nonstrict" [lambdaNonStrict `unsafeApplyCode` bot]
     , goldenPirReadable "lambda-nonstrict" lambdaNonStrict
     , goldenUPlcReadable "lambda-nonstrict" lambdaNonStrict
 
-    , goldenEvalCekCatch "lambda-strict" [lambdaStrict `unsafeApplyCode` bot]
+    , goldenEvalCekCatchBudget "lambda-strict" [lambdaStrict `unsafeApplyCode` bot]
     , goldenPirReadable "lambda-strict" lambdaStrict
     , goldenUPlcReadable "lambda-strict" lambdaStrict
 
     -- FIXME: This should crash (because the `Strict` extension is on), but it currently doesn't.
-    , goldenEvalCekCatch "let-default" [letDefault `unsafeApplyCode` one]
+    , goldenEvalCekCatchBudget "let-default" [letDefault `unsafeApplyCode` one]
     , goldenPirReadable "let-default" letDefault
     , goldenUPlcReadable "let-default" letDefault
 
-    , goldenEvalCekCatch "let-nonstrict" [letNonStrict `unsafeApplyCode` one]
+    , goldenEvalCekCatchBudget "let-nonstrict" [letNonStrict `unsafeApplyCode` one]
     , goldenPirReadable "let-nonstrict" letNonStrict
     , goldenUPlcReadable "let-nonstrict" letNonStrict
 
     -- FIXME: This should crash, but it currently doesn't.
-    , goldenEvalCekCatch "let-strict" [letStrict `unsafeApplyCode` one]
+    , goldenEvalCekCatchBudget "let-strict" [letStrict `unsafeApplyCode` one]
     , goldenPirReadable "let-strict" letStrict
     , goldenUPlcReadable "let-strict" letStrict
     ]

plutus-tx/testlib/PlutusTx/Test.hs

@@ -25,13 +25,9 @@ module PlutusTx.Test (
 
   -- * Evaluation testing
   goldenEvalCek,
-  goldenEvalCekCatch,
   goldenEvalCekLog,
   goldenEvalCekCatchBudget,
 
-  -- * Budget and size testing
-  goldenBudget,
-
   -- * Combined testing
   goldenBundle,
   goldenBundle'
@@ -119,23 +115,6 @@ renderExcess :: (TestName, Integer) -> (TestName, Integer) -> Integer -> String
 renderExcess tData mData diff =
   renderEstimates tData mData <> "Remaining headroom: " <> show diff
 
-{- | Does not include evaluation result. To include evaluation result, use
-  `goldenEvalCekCatchBudget` instead of adding `goldenEvalCekCatch`
--}
-goldenBudget :: TestName -> CompiledCode a -> TestNested
-goldenBudget name compiledCode = do
-  nestedGoldenVsDocM name ".budget" $ ppCatch $ do
-    (_, PLC.ExBudget cpu mem) <- runPlcCekBudget [compiledCode]
-    size <- UPLC.programSize <$> toUPlc compiledCode
-    let contents =
-          "cpu: "
-            <> pretty cpu
-            <> "\nmem: "
-            <> pretty mem
-            <> "\nsize: "
-            <> pretty size
-    pure (render @Text contents)
-
 goldenBundle
   :: TestName
   -> CompiledCodeIn UPLC.DefaultUni UPLC.DefaultFun a
@@ -210,12 +189,6 @@ goldenEvalCek name values =
   nestedGoldenVsDocM name ".eval" $
     prettyPlcClassicSimple <$> rethrow (runPlcCek values)
 
-goldenEvalCekCatch :: (ToUPlc a PLC.DefaultUni PLC.DefaultFun) => TestName -> [a] -> TestNested
-goldenEvalCekCatch name values =
-  nestedGoldenVsDocM name ".eval" $
-    either (pretty . show) prettyPlcClassicSimple
-      <$> runExceptT (runPlcCek values)
-
 goldenEvalCekLog :: (ToUPlc a PLC.DefaultUni PLC.DefaultFun) => TestName -> [a] -> TestNested
 goldenEvalCekLog name values =
   nestedGoldenVsDocM name ".eval" $