Skip to content

Commit 057771a

Browse files
committed
remove guava by using modern java features
1 parent e609fbf commit 057771a

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

glsl-preprocessor/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ version = '0.0.1'
1919
dependencies {
2020
api group: 'org.slf4j', name: 'slf4j-simple', version: '2.0.+'
2121
implementation group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: '4.7.3'
22-
testImplementation group: 'com.google.guava', name: 'guava', version: '18.0'
2322
}
2423

2524
testing {

glsl-preprocessor/src/test/java/org/anarres/cpp/PragmaTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@
88
import static org.junit.jupiter.api.Assertions.*;
99

1010
import java.io.File;
11+
import java.nio.file.Files;
1112

1213
import org.junit.jupiter.api.Test;
1314
import org.slf4j.*;
1415

15-
import com.google.common.base.Charsets;
16-
import com.google.common.io.Files;
17-
1816
/**
1917
*
2018
* @author shevek
@@ -28,7 +26,7 @@ public void testPragma() throws Exception {
2826
assertTrue(file.exists());
2927

3028
// create a CharSource from a file
31-
Preprocessor pp = new Preprocessor(Files.newReader(file, Charsets.UTF_8));
29+
Preprocessor pp = new Preprocessor(Files.newBufferedReader(file.toPath()));
3230
pp.setListener(new DefaultPreprocessorListener());
3331
String output = pp.printToString();
3432
pp.close();

glsl-preprocessor/src/test/java/org/anarres/cpp/RegressionTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,14 @@
88
import static org.junit.jupiter.api.Assertions.*;
99

1010
import java.io.*;
11+
import java.nio.file.Files;
1112
import java.util.Arrays;
1213
import java.util.stream.Stream;
1314

1415
import org.junit.jupiter.params.ParameterizedTest;
1516
import org.junit.jupiter.params.provider.*;
1617
import org.slf4j.*;
1718

18-
import com.google.common.base.Charsets;
19-
import com.google.common.io.*;
20-
2119
/**
2220
*
2321
* @author shevek
@@ -28,23 +26,25 @@ public class RegressionTest {
2826

2927
public static Stream<Arguments> data() throws Exception {
3028
File dir = new File("build/resources/test/regression");
31-
return Arrays.stream(dir.listFiles(new PatternFilenameFilter(".*\\.in"))).map(inFile -> {
32-
String name = Files.getNameWithoutExtension(inFile.getName());
33-
File outFile = new File(dir, name + ".out");
34-
return Arguments.of(name, inFile, outFile);
35-
});
29+
return Arrays.stream(dir.listFiles())
30+
.filter(inFile -> inFile.getName().endsWith(".in"))
31+
.map(inFile -> {
32+
String name = inFile.getName().replace(".in", "");
33+
File outFile = new File(dir, name + ".out");
34+
return Arguments.of(name, inFile, outFile);
35+
});
3636
}
3737

3838
@ParameterizedTest
3939
@MethodSource("data")
4040
public void testRegression(String name, File inFile, File outFile) throws Exception {
41-
String inText = Files.toString(inFile, Charsets.UTF_8);
41+
String inText = Files.readString(inFile.toPath());
4242
LOG.info("Read " + name + ":\n" + inText);
4343
Preprocessor pp = new Preprocessor(new StringReader(inText));
4444
String generatedText = pp.printToString();
4545
LOG.info("Generated " + name + ":\n" + generatedText);
4646
if (outFile.exists()) {
47-
String outText = Files.toString(outFile, Charsets.UTF_8);
47+
String outText = Files.readString(outFile.toPath());
4848
LOG.info("Expected " + name + ":\n" + outText);
4949
assertEquals(outText, inText);
5050
}

0 commit comments

Comments
 (0)