Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of rows (= actions) returned by get_action in SbAgent #33

Open
rahulsavani opened this issue May 26, 2023 · 0 comments
Open

number of rows (= actions) returned by get_action in SbAgent #33

rahulsavani opened this issue May 26, 2023 · 0 comments

Comments

@rahulsavani
Copy link
Collaborator

The old method

    # return self.model.predict(state, deterministic=True)[0].reshape(self.num_trajectories, self.num_actions)

used self.num_trajectories as the number of different actions to return, but this was failing in some cases due to a discrepancy between self.num_tracjectories and the actual state given to model predict

Leandro and Rahul changed this to

    return self.model.predict(state, deterministic=True)[0].reshape(state.shape[0], self.num_actions)

Are we happy with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant