Skip to content

Increase uniqueness of CR LF NL defines (or remove) as these can cause conflicts with other libraries #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mattbaker-digital opened this issue Jul 13, 2024 · 0 comments · May be fixed by #5
Open

Increase uniqueness of CR LF NL defines (or remove) as these can cause conflicts with other libraries #2

mattbaker-digital opened this issue Jul 13, 2024 · 0 comments · May be fixed by #5

Comments

@mattbaker-digital
Copy link

mattbaker-digital commented Jul 13, 2024 •
edited
Loading

CR LF and NL are way too generic for effectively global namespace and can cause conflicts with other libraries.

For me, it resulted the following error: error: expected unqualified-id before string constant

image
mattbaker-digital pushed a commit to mattbaker-digital/Arduino-Log that referenced this issue Aug 16, 2024
@matt-baker-agd-systems
Add build flag to disable line end defines
c0a25e0 
ARDUINOLOG_DISABLE_LINE_END_DEFINES

Fixes JSC-TechMinds#2
@mattbaker-digital mattbaker-digital linked a pull request Aug 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add build flag to disable line end defines mattbaker-digital/Arduino-Log
1 participant
@mattbaker-digital