You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setting endpoint to custom with value that is not parseable (e.g "saffga") will make the app crash. It will crash on every consequent startup until the app data is cleared.
The reason is that the user inputed string is saved to @ApiEndpoint String preference, which is later read by provideHttpUrl method in DebugApiModule. The method tries to parse the String into HttpUrl but invalid Strings are parsed to null value. When nullHttpUrl is provided as a base url when building retrofit instance, the app will crash.
Fix: Make sure user provided custom URL is parseable. Additional validation is required when custom endpoint is set by the user(within DebugView, check if it is parseable by HttpUrl.parse() method). I've made pull request for this but I guess I'm not allowed to push anything to this repo.
The text was updated successfully, but these errors were encountered:
Setting endpoint to custom with value that is not parseable (e.g "saffga") will make the app crash. It will crash on every consequent startup until the app data is cleared.
The reason is that the user inputed string is saved to
@ApiEndpoint
String preference, which is later read byprovideHttpUrl
method inDebugApiModule
. The method tries to parse the String intoHttpUrl
but invalid Strings are parsed tonull
value. Whennull
HttpUrl
is provided as a base url when building retrofit instance, the app will crash.Fix: Make sure user provided custom URL is parseable. Additional validation is required when custom endpoint is set by the user(within
DebugView
, check if it is parseable byHttpUrl.parse()
method). I've made pull request for this but I guess I'm not allowed to push anything to this repo.The text was updated successfully, but these errors were encountered: