Compilation issue

[murlock]

Hi,

I've tried to compile openmom on my Ubuntu:

• with GCC 7.3, I've met few issues with invalid compilation flags, missing headers but also some method seen as constructor !
• with clang 4.0, some errors are raised related to SkillSet::iterator with invalid operands.

Can you describe which version of clang on Mac is used to compile ?
Regarding your cmake, I suppose you are using Mac and/or Windows ?

[rtentser]

gcc 6.3.0, clang 3.8.1-24, Debian GNU/Linux stretch:
openmom_build.log

[rtentser]

I've fixed some errors by including some headers (https://github.com/rtentser/openmom/tree/compilationFixes) and using -fpermissive flag lets gcc to ignore some other issues (it's temporary solution, but i don't want to look into them right now). And now i stuck with another problem. I've attached the log. I'll try to fix it too but it's been a while since i wrote in C++ and i wasn't good, so i need time to refresh my skills. Any help will be appreciated.
openmom_build2.log

[Jakz]

So far I'm mainly working with XCode, I created the cmake project so that someone could help in configuring it for additional platforms but I haven't personally tested it too much on other operating systems.

My main machine has this clang/LLVM version:

Apple LLVM version 8.0.0 (clang-800.0.42.1)

XCode has some predefined headers which indeed must be added to allow compilation through a different build system, I'd be glad if you are able to provide a pull request which fixes compilation under your version of linux as it's really welcome :)

[rtentser]

Right now i've fixed or workarounded some of compilation issues on my system (PULL: #4). But that isn't all.

[murlock]

Thanks, I'll try with new updates and will upgrade my clang version ! Regards Le sam. 24 nov. 2018 à 08:07, rtentser <notifications@github.com> a écrit :

…

Right now i've fixed or workarounded some of compilation issues on my system (PULL: #4 <#4>). But that isn't all. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPTAQVXTDv0SqwEc44477OyhpX9So_Zks5uyPAWgaJpZM4YcjkF> .

-- Michael Bonfils ( http://www.murlock.org )

[Jakz]

@rtentser: It's not clear if now it compiles with -fpermissive on your machine or if it still requires fixes, I merged the PR meanwhile, in case it wasn't complete please specify it directly in the text of the PR so that I'll avoid merging it.

If another PR is needed then feel free to open it. I'll try to setup a bare Linux environment to test compilation too.

[Jakz]

Ok, I prepared the environment and tested compilation on clang-3.8. Added some fixes that I already integrated into master branch, now it should reach linking phase, could @rtentser please confirm this?

[rtentser]

It wasn't finished: there was a problem with operator- for iterator and you've fixed it. Thanks a lot (and for other fixes too)!

There was some filenames issues still, i've fixed them: #7

Now it's 100%, "Linking CXX executable openmom" and many errors.

I've fixed -fpermissive issues earlier, so we don't need this flag anymore.

[Jakz]

I added some more fixes which should solve linking problems on Linux, now the executable should be correctly created but it crashes at startup (another story!).

[rtentser]

/home/rtentser/Sources/openmom/src/save/YAML.cpp:5:27: fatal error: yaml-cpp/yaml.h: No such file or directory

[rtentser]

Fixes: #8

But linking doesn't starts:

make[2]: *** No rule to make target '/yaml/lib/linux/libyaml-cpp.a', needed by 'openmom'.  Stop.
CMakeFiles/Makefile2:86: recipe for target 'CMakeFiles/openmom.dir/all' failed
make[1]: *** [CMakeFiles/openmom.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Also, Debian and Ubuntu have libyaml-cpp-dev package: https://packages.debian.org/stretch/libyaml-cpp-dev. Can you use it?

[rtentser]

Here is content of a package in Debian Stretch i386:
/usr/include/yaml-cpp/anchor.h
/usr/include/yaml-cpp/binary.h
/usr/include/yaml-cpp/contrib/anchordict.h
/usr/include/yaml-cpp/contrib/graphbuilder.h
/usr/include/yaml-cpp/dll.h
/usr/include/yaml-cpp/emitfromevents.h
/usr/include/yaml-cpp/emitter.h
/usr/include/yaml-cpp/emitterdef.h
/usr/include/yaml-cpp/emittermanip.h
/usr/include/yaml-cpp/emitterstyle.h
/usr/include/yaml-cpp/eventhandler.h
/usr/include/yaml-cpp/exceptions.h
/usr/include/yaml-cpp/mark.h
/usr/include/yaml-cpp/node/convert.h
/usr/include/yaml-cpp/node/detail/bool_type.h
/usr/include/yaml-cpp/node/detail/impl.h
/usr/include/yaml-cpp/node/detail/iterator.h
/usr/include/yaml-cpp/node/detail/iterator_fwd.h
/usr/include/yaml-cpp/node/detail/memory.h
/usr/include/yaml-cpp/node/detail/node.h
/usr/include/yaml-cpp/node/detail/node_data.h
/usr/include/yaml-cpp/node/detail/node_iterator.h
/usr/include/yaml-cpp/node/detail/node_ref.h
/usr/include/yaml-cpp/node/emit.h
/usr/include/yaml-cpp/node/impl.h
/usr/include/yaml-cpp/node/iterator.h
/usr/include/yaml-cpp/node/node.h
/usr/include/yaml-cpp/node/parse.h
/usr/include/yaml-cpp/node/ptr.h
/usr/include/yaml-cpp/node/type.h
/usr/include/yaml-cpp/noncopyable.h
/usr/include/yaml-cpp/null.h
/usr/include/yaml-cpp/ostream_wrapper.h
/usr/include/yaml-cpp/parser.h
/usr/include/yaml-cpp/stlemitter.h
/usr/include/yaml-cpp/traits.h
/usr/include/yaml-cpp/yaml.h
/usr/lib/i386-linux-gnu/cmake/yaml-cpp/yaml-cpp-config-version.cmake
/usr/lib/i386-linux-gnu/cmake/yaml-cpp/yaml-cpp-config.cmake
/usr/lib/i386-linux-gnu/cmake/yaml-cpp/yaml-cpp-targets-release.cmake
/usr/lib/i386-linux-gnu/cmake/yaml-cpp/yaml-cpp-targets.cmake
/usr/lib/i386-linux-gnu/libyaml-cpp.a
/usr/lib/i386-linux-gnu/libyaml-cpp.so
/usr/lib/i386-linux-gnu/pkgconfig/yaml-cpp.pc
/usr/share/doc/libyaml-cpp-dev/changelog.Debian.gz
/usr/share/doc/libyaml-cpp-dev/copyright

[rtentser]

I've tried to build openmom without my changes after i've installed the package and get some other errors:

openmom.log

[Jakz]

I did some local enhancements to the library so that's why I would prefer avoiding using the package (and I'm not even sure all distributions have it), I think the problem you get is related to

set(LIBRARY_FOLDER ${CMAKE_CURRENT_SOURCE_DIR}/libs)

in root CMakeFiles.txt which is not propagated to the CMakeFiles.txt in the subfolders so that it's empty, and subsequent

set(YAML_INCLUDE_DIR ${LIBRARY_FOLDER}/yaml/include)

fails. If you fix it you don't need to change all includes (which should be kept with yaml-cpp since this is required on macOS).