Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting past meeting API reveals Meeting class instead of PastMeeting #231

Closed
pzelenko opened this issue Aug 2, 2022 · 7 comments
Closed
Assignees
Labels
Bug This change resolves a defect
Milestone

Comments

@pzelenko
Copy link
Contributor

pzelenko commented Aug 2, 2022

Hi Jericho,

I noticed that getting past meeting API (GetAsync() API) returns ref of Meeting class instead of PastMeeting class (defined in ZoomNet/Source/ZoomNet/Models/PastMeeting.cs file).

public interface IPastMeetings
{
    /// Retrieve the details of a meeting that occured in the past.
    /// <param name="uuid">The meeting UUID.</param>
    /// <param name="cancellationToken">The cancellation token.</param>
    /// <returns>
    /// The <see cref="Meeting" />.
    /// </returns>
    Task<Meeting> GetAsync(string uuid, CancellationToken cancellationToken = default)
}

While Zoom REST API past_meetings returns information about past meeting including actual start/end time of the finished meeting. Here is the sample result of REST API call:

    "uuid": "*****",
    "id": *****,
    "host_id": "**********",
    "type": 2,
    "topic": "Test meeting 15 min",
    "user_name": "*******user_name",
    "user_email": "******user_mail",
    "start_time": "2022-07-22T15:26:17Z",
    "end_time": "2022-07-22T15:29:50Z",
    "duration": 4,
    "total_minutes": 4,
    "participants_count": 1,
    "dept": "",
    "source": "Zoom"

What is the reason you are not returning PastMeeting class, which has all the attributes above?
I could not find another way of getting past meeting actual start/end time using ZoomNet

Thanks in advance

@Jericho Jericho added the Bug This change resolves a defect label Aug 2, 2022
@Jericho Jericho self-assigned this Aug 2, 2022
@Jericho Jericho added this to the 0.47.0 milestone Aug 2, 2022
@Jericho
Copy link
Owner

Jericho commented Aug 2, 2022

My best guess is that this is a copy/paste mistake on my part. The return type of this method definitely should be PastMeeting.

@pzelenko
Copy link
Contributor Author

pzelenko commented Aug 2, 2022

Thanks a lot for a quick response. What do you think, when can we expect a release with this fix?

@Jericho
Copy link
Owner

Jericho commented Aug 2, 2022

You reported this issue barely an hour ago and already you expect a fix and a release !!! 😜

Joking aside, I should be able to publish a release in the next day or two.

@pzelenko
Copy link
Contributor Author

pzelenko commented Aug 3, 2022

Great! Thanks a lot for your great support. I am actively using your package, that's the reason for such a rush :)
BTW, does the package support Zoom Phone API ?

@Jericho
Copy link
Owner

Jericho commented Aug 3, 2022

does the package support Zoom Phone API ?

There are several endpoints in Zoom's API that I haven't worked on, mostly due to the fact that I don't have the necessary permissions to access them. I applied for membership in Zoom's partner program (which, I assume, would grant me access to the entirety of the API) but never heard back. I also asked for assistance, but so far no progress has been made.

@Jericho Jericho closed this as completed Aug 3, 2022
@Jericho
Copy link
Owner

Jericho commented Aug 3, 2022

🎉 This issue has been resolved in version 0.47.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@pzelenko
Copy link
Contributor Author

pzelenko commented Aug 3, 2022

Well done, thank you! It is working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This change resolves a defect
Projects
None yet
Development

No branches or pull requests

2 participants