-
Notifications
You must be signed in to change notification settings - Fork 105
Type hints for Pin class are incomplete #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Streyder Thanks for reporting it. A pull request with missing type hints is welcome. |
I implemented the changes on my end. Sadly I am not allowed to create a new branch to create a pull request. Actually I don't know how I would make a proper pull request. Maybe you can help out. |
@Streyder We use the standard GitHub workflow for pull requests to this repository, I'm sure there are good tutorials about pull requests on GitHub. The basic idea is that you close this repository to your account, so it becomes github.com/Streyder/intellij-micropython, then you create your new branch there and then GitHub will show you the message about creating a pull request to the original repository on the page of your clone. |
Created pullrequest 63 for this issue |
Closing it as a duplicate of #16. |
Hey,
the Pin class is sadly lacking some type hints. For example Pin.board.X, Pin.high() and Pin.low() are missing.
Cheers
Kevin
The text was updated successfully, but these errors were encountered: