Skip to content

Type hints for Pin class are incomplete #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Streyder opened this issue Jun 21, 2018 · 5 comments
Closed

Type hints for Pin class are incomplete #60

Streyder opened this issue Jun 21, 2018 · 5 comments

Comments

@Streyder
Copy link

Streyder commented Jun 21, 2018

Hey,

the Pin class is sadly lacking some type hints. For example Pin.board.X, Pin.high() and Pin.low() are missing.

Cheers
Kevin

@Streyder Streyder changed the title Pin class is not included completely Type hints for Pin class are incomplete Jun 21, 2018
@vlasovskikh
Copy link
Contributor

@Streyder Thanks for reporting it. A pull request with missing type hints is welcome.

@Streyder
Copy link
Author

Streyder commented Aug 9, 2018

I implemented the changes on my end. Sadly I am not allowed to create a new branch to create a pull request. Actually I don't know how I would make a proper pull request. Maybe you can help out.

@vlasovskikh
Copy link
Contributor

@Streyder We use the standard GitHub workflow for pull requests to this repository, I'm sure there are good tutorials about pull requests on GitHub. The basic idea is that you close this repository to your account, so it becomes github.com/Streyder/intellij-micropython, then you create your new branch there and then GitHub will show you the message about creating a pull request to the original repository on the page of your clone.

@Streyder
Copy link
Author

Created pullrequest 63 for this issue

@vlasovskikh
Copy link
Contributor

Closing it as a duplicate of #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants