-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BoxDecoration theme to header container and hours container (left side) #39
Comments
Until this is implemented: The For the hours (painted by The issues are no problem, that's what they're for :) Do you have an estimate of when you need these features in your project? With #17 in mind, I'm not sure if it's worth adding customization options in this "old" version. I hope I can start implementing the new architecture in week 32 (3 weeks from now) when most of our exams are over, and a version with a mostly stable API and the current features (potentially more) should be available within a week from then, as my lectures are over soon. |
yep, I saw that it's just a Overall theme prop for the header may solve some simple cases (and probably most common ones), while the ability to make own layout from I personally would like to have both))) theme prop - if I want some small customization like a shadow for example, and exposed Widget - for much deeper customization |
Yesterday 😁 kidding) but overall, the case here that I will need something similar to Google calendar (it's layout itself) Currently, in this package, there are no delimiters like border or shadow between content and header, and since both of them have white background, I'm sure on 100% that our designer will ask to add anything to split them) the problem is that I don't know when it will be, but I know that this moment will come for sure) |
maybe (from the UX standpoint, not specific to my case) header is needed its own default decoration? similar to Google calendar maybe. But pitfall of this solution - this can be counted as a breaking changes |
but, if something, I can use my fork until #17 will be done, not a problem at all |
I'd prefer it if you use the fork for this customization until #17 is done. I'll think about using some kind of divider by default in the future |
sure, no problem at all) |
@JonasWanke btw, just a note, when you will be adding customization, maybe you can also change the order of the widgets in the body. The issue is that currently regular direction for a column is used (header, content). This means that content is actually placed above the header in the tree in terms of z-index positioning. Which creates some problems with decoration apply to the header like shadow, because content overlays it. Just something to keep in mind) |
Add the ability to define BoxDecoration for the header container and hours container.
It will be useful to keep the timetable up to date with any custom theme (like shadows aka Material elevation, shapes, borders and etc.) that dev is using in his App.
P.S. Sorry that I'm spamming your package with issues)) But everything that I create is something that I need in my current task)
The text was updated successfully, but these errors were encountered: