Skip to content

Commit 4a1d671

Browse files
Merge pull request #119 from JsDaddy/feat/118
Feat/118
2 parents 6517ca3 + 564e1fb commit 4a1d671

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+476
-385
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+13-13
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@
22

33
Please check if your PR fulfills the following requirements:
44

5-
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
6-
- [ ] Tests for the changes have been added (for bug fixes / features)
7-
- [ ] Docs have been added / updated (for bug fixes / features)
5+
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
6+
- [ ] Tests for the changes have been added (for bug fixes / features)
7+
- [ ] Docs have been added / updated (for bug fixes / features)
88

99
## PR Type
1010

1111
What kind of change does this PR introduce?
1212

1313
<!-- Please check the one that applies to this PR using "x". -->
1414

15-
- [ ] Bugfix
16-
- [ ] Feature
17-
- [ ] Code style update (formatting, local variables)
18-
- [ ] Refactoring (no functional changes, no api changes)
19-
- [ ] Build related changes
20-
- [ ] CI related changes
21-
- [ ] Documentation content changes
22-
- [ ] Other... Please describe:
15+
- [ ] Bugfix
16+
- [ ] Feature
17+
- [ ] Code style update (formatting, local variables)
18+
- [ ] Refactoring (no functional changes, no api changes)
19+
- [ ] Build related changes
20+
- [ ] CI related changes
21+
- [ ] Documentation content changes
22+
- [ ] Other... Please describe:
2323

2424
## What is the current behavior?
2525

@@ -31,8 +31,8 @@ Issue Number: N/A
3131

3232
## Does this PR introduce a breaking change?
3333

34-
- [ ] Yes
35-
- [ ] No
34+
- [ ] Yes
35+
- [ ] No
3636

3737
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
3838

.github/workflows/gh-pages.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
with:
2020
node-version: 20
2121

22-
- uses: oven-sh/setup-bun@v1
22+
- uses: oven-sh/setup-bun@v2
2323
with:
2424
bun-version: latest
2525

@@ -45,7 +45,7 @@ jobs:
4545
bun run build
4646
4747
- name: Deploy demo
48-
uses: peaceiris/actions-gh-pages@v3
48+
uses: peaceiris/actions-gh-pages@v4
4949
with:
5050
github_token: ${{ secrets.GITHUB_TOKEN }}
5151
publish_dir: ./dist/angular-loader/browser
@@ -59,7 +59,7 @@ jobs:
5959
steps:
6060
- name: Post to a Slack channel
6161
id: slack
62-
uses: slackapi/slack-github-action@v1.26.0
62+
uses: slackapi/slack-github-action@v1.27.0
6363
with:
6464
channel-id: 'deployments'
6565
payload: |

.github/workflows/publish.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Publish npm
1+
name: Publish bun
22

33
on:
44
push:
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/checkout@v4
1313
with:
1414
submodules: true
15-
- uses: oven-sh/setup-bun@v1
15+
- uses: oven-sh/setup-bun@v2
1616
with:
1717
bun-version: latest
1818
- uses: actions/setup-node@v4

.github/workflows/quality-check.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
with:
2323
submodules: true
2424
ref: ${{ env.REF }}
25-
- uses: oven-sh/setup-bun@v1
25+
- uses: oven-sh/setup-bun@v2
2626
with:
2727
bun-version: latest
2828
- uses: actions/setup-node@v4

.lintstagedrc

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"*.{ts,js,json}": [
33
"eslint --report-unused-disable-directives --max-warnings 0 --fix",
4-
"prettier --write"
4+
"prettier . --write"
55
],
66
"*.scss": "stylelint --fix"
7-
}
7+
}

.releaserc.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
branches:
2-
- develop
2+
- develop
33

44
plugins:
5-
- '@semantic-release/commit-analyzer'
6-
- '@semantic-release/github'
7-
- 'semantic-release-export-data'
5+
- '@semantic-release/commit-analyzer'
6+
- '@semantic-release/github'
7+
- 'semantic-release-export-data'

.stylelintignore

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
/tmp
44
/out-tsc
55
/bazel-out
6+
/src/styles.scss
67

78
# Node
89
/node_modules

.stylelintrc.json

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"customSyntax": "postcss-scss",
44
"plugins": ["stylelint-prettier"],
55
"rules": {
6+
"no-empty-source": null,
7+
"scss/comment-no-empty": null,
8+
"no-descending-specificity": null,
69
"prettier/prettier": true,
710
"selector-type-no-unknown": [
811
true,

CHANGELOG.md

+18-11
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,57 @@
1+
# 18.0.4(2024-10-25)
2+
3+
### Feature
4+
5+
- add tailwind
6+
- change interface to type, remove prefix "I"
7+
- update dependencies
8+
- add ESLint strict rules
9+
110
# 17.3.2(2024-03-29)
211

312
### Feature
413

5-
- change decorators to signals
14+
- change decorators to signals
615

716
<a name="17.0.0"></a>
817

918
# 17.0.0(2023-11-28)
1019

1120
### Feature
1221

13-
- update ng 17.x
22+
- update ng 17.x
1423

1524
<a name="17.0.0"></a>
1625

17-
1826
# 16.0.1(2023-10-03)
1927

2028
### Feature
2129

22-
- update dependencies
30+
- update dependencies
2331

2432
# 16.0.0(2023-07-07)
2533

2634
### Feature
2735

28-
- update ng 16.x
36+
- update ng 16.x
2937

3038
<a name="16.0.0"></a>
3139

3240
# 15.0.0(2022-26-12)
3341

3442
### Feature
35-
- update to ng15
3643

37-
<a name="15.0.0"></a>
44+
- update to ng15
3845

46+
<a name="15.0.0"></a>
3947

4048
<a name="6.0.0"></a>
41-
# [6.0.0 base functionality] (2018-05-17)
4249

50+
# [6.0.0 base functionality] (2018-05-17)
4351

4452
<a name="6.1.0"></a>
53+
4554
# [6.1.0 base functionality] (2018-05-21)
46-
55+
4756
<p>Custom styles(background, color, size) for image and wrapper</p>
4857
<p>Custom animations for image rotation</p>
49-
50-

CONTRIBUTING.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ Please format code and markup in your issue using [github markdown](https://help
88

99
## Contributing to Source Code (Pull Requests)
1010

11-
- If your PR changes any behavior or fixes an issue, it should have an associated test.
12-
- New features should be general and as simple as possible.
13-
- Breaking changes should be avoided if possible.
14-
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
11+
- If your PR changes any behavior or fixes an issue, it should have an associated test.
12+
- New features should be general and as simple as possible.
13+
- Breaking changes should be avoided if possible.
14+
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
1515

1616
## Protractor specific rules
1717

18-
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
19-
- Document public methods with jsdoc.
20-
- Be consistent with the code around you!
18+
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
19+
- Document public methods with jsdoc.
20+
- Be consistent with the code around you!
2121

2222
## Commit Messages
2323

README.md

+15-10
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
You can also try our NGX MASK [check](https://www.npmjs.com/package/ngx-mask) it.
2020
You can also try our NGX COPYPASTE [check](https://www.npmjs.com/package/ngx-copypaste) it.
21-
### You can try live [demo](https://jsdaddy.github.io/ngx-loader-indicator/) with examples.
21+
22+
### You can try live [demo](https://jsdaddy.github.io/ngx-loader-indicator/) with examples.
23+
2224
## Installing
2325

2426
```bash
@@ -39,7 +41,7 @@ bootstrapApplication(AppComponent, {
3941
(...)
4042
],
4143
}).catch((err) => console.error(err));
42-
````
44+
```
4345

4446
or configure for feature with `provideNgxLoaderIndicator` and import standalone directive `NgxLoaderIndicatorDirective`
4547

@@ -68,7 +70,7 @@ or configure for feature with `provideNgxLoaderIndicator` and import standalone
6870
],
6971
})
7072
export class MyFeatureComponent {}
71-
````
73+
```
7274

7375
## Quickstart if ngx-loader-indicator version < 15.0.0
7476

@@ -93,25 +95,26 @@ import {NgxLoaderIndicatorModule} from 'ngx-loader-indicator'
9395
### Usage
9496

9597
```html
96-
<div [ngxLoaderIndicator]="isLoading">Content</div>
98+
<div [ngxLoaderIndicator]="isLoading">Content</div>
9799
```
98100

99101
#### Examples
100102

101103
```html
102104
<form (ngSubmit)="save(form.value)" [formGroup]="form" [ngxLoaderIndicator]="isLoading">
103-
<h2>Login</h2>
104-
<input matInput type="email" placeholder="Email" #email formControlName="email">
105-
<input matInput type="password" placeholder="Password" #name formControlName="password">
106-
<button mat-button [disabled]="form.invalid">Login</button>
105+
<h2>Login</h2>
106+
<input matInput type="email" placeholder="Email" #email formControlName="email" />
107+
<input matInput type="password" placeholder="Password" #name formControlName="password" />
108+
<button mat-button [disabled]="form.invalid">Login</button>
107109
</form>
108110
```
109111

110112
## Options
111-
You can define your custom options
112113

114+
You can define your custom options
113115

114116
### custom img (string) and colors
117+
115118
```typescript
116119
{
117120
img: string,
@@ -123,6 +126,7 @@ You can define your custom options
123126
```
124127

125128
### custom wrapper layout colors
129+
126130
```typescript
127131
{
128132
loaderStyles: {
@@ -132,6 +136,7 @@ You can define your custom options
132136
```
133137

134138
### animations options for image rotation
139+
135140
```typescript
136141
rotate: {
137142
delay?: number;
@@ -146,8 +151,8 @@ You can define your custom options
146151
},
147152
```
148153

149-
150154
### Usage
155+
151156
```typescript
152157
import {NgxLoaderIndicatorModule} from 'ngx-loader-indicator'
153158

bun.lockb

15.8 KB
Binary file not shown.

0 commit comments

Comments
 (0)