improve coverage

Author: mateuszbaran

src/StaticArraysCore.jl

@@ -56,14 +56,6 @@ Base.@pure function size_to_tuple(::Type{S}) where S<:Tuple
 end
 
 # Something doesn't match up type wise
-function check_array_parameters(Size, T, N, L)
-    (!isa(Size, DataType) || (Size.name !== Tuple.name)) && throw(ArgumentError("Static Array parameter Size must be a Tuple type, got $Size"))
-    !isa(T, Type) && throw(ArgumentError("Static Array parameter T must be a type, got $T"))
-    !isa(N.parameters[1], Int) && throw(ArgumentError("Static Array parameter N must be an integer, got $(N.parameters[1])"))
-    !isa(L.parameters[1], Int) && throw(ArgumentError("Static Array parameter L must be an integer, got $(L.parameters[1])"))
-    # shouldn't reach here. Anything else should have made it to the function below
-    error("Internal error. Please file a bug")
-end
 @generated function check_array_parameters(::Type{Size}, ::Type{T}, ::Type{Val{N}}, ::Type{Val{L}}) where {Size,T,N,L}
     if !all(x->isa(x, Int), Size.parameters)
         return :(throw(ArgumentError("Static Array parameter Size must be a tuple of Ints (e.g. `SArray{Tuple{3,3}}` or `SMatrix{3,3}`).")))
@@ -77,8 +69,6 @@ end
 end
 
 # Cast any Tuple to an TupleN{T}
-@inline convert_ntuple(::Type{T},d::T) where {T} = T # For zero-dimensional arrays
-@inline convert_ntuple(::Type{T},d::NTuple{N,T}) where {N,T} = d
 @generated function convert_ntuple(::Type{T}, d::NTuple{N,Any}) where {N,T}
     exprs = ntuple(i -> :(convert(T, d[$i])), Val(N))
     return quote

test/runtests.jl

@@ -6,6 +6,7 @@ using StaticArraysCore: SizedArray, SizedVector, SizedMatrix
 
 @testset "types" begin
     @test SArray{Tuple{2},Int,1}((1, 2)) isa SArray
+    @test_throws ArgumentError SArray{Tuple{2},Int,2}((1, 2))
     @test SArray{Tuple{2},Float64,1}((1, 2)) isa SVector{2,Float64}
     @test SVector{2,Int}((1, 2)) isa SVector
     @test SMatrix{1,2,Int}((1, 2)) isa SMatrix
@@ -17,5 +18,12 @@ using StaticArraysCore: SizedArray, SizedVector, SizedMatrix
     @test MMatrix{1,2,Int}((1, 2)) isa MMatrix
 
     @test SizedArray{Tuple{2},Int,2,1,Vector{Int}}([1, 2]) isa SizedArray
+    @test_throws DimensionMismatch SizedArray{Tuple{2},Int,2,1,Vector{Int}}([1, 2, 3]) isa SizedArray
     @test SizedArray{Tuple{2},Int,2,1,Vector{Int}}(undef) isa SizedArray
+    @test SizedArray{Tuple{2,3},Int,2,2,Matrix{Int}}(undef) isa SizedArray
+
+    @test_throws ArgumentError StaticArraysCore.check_array_parameters(Tuple{2.0}, Int, Val{2}, Val{2})
+    @test StaticArraysCore.tuple_length((5, 3)) == 2
+    @test StaticArraysCore.tuple_prod((5, 3)) == 15
+    @test StaticArraysCore.tuple_minimum((5, 3)) == 3
 end