`construct_seeds` for types where `typeof(one(T)) !=T` is broken

as far as i understand, the type of `one(T)` is not necessarily `T` (https://github.com/JuliaPhysics/Measurements.jl/issues/134 for example). but `construct_seeds` uses this:
https://github.com/JuliaDiff/ForwardDiff.jl/blob/50ec9a1ccb0a4390edc88398aa322656d58e7202/src/partials.jl#L9-L12
Maybe using `oneunit` there is more correct?

	@generated function single_seed(::Type{Partials{N,V}}, ::Val{i}) where {N,V,i}
	ex = Expr(:tuple, [ifelse(i === j, :(one(V)), :(zero(V))) for j in 1:N]...)
	return :(Partials($(ex)))
	end

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`construct_seeds` for types where `typeof(one(T)) !=T` is broken #651

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

construct_seeds for types where typeof(one(T)) !=T is broken #651

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`construct_seeds` for types where `typeof(one(T)) !=T` is broken #651