Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

GPU tests don't test anything #307

Open
gdalle opened this issue Oct 7, 2024 · 1 comment
Open

GPU tests don't test anything #307

gdalle opened this issue Oct 7, 2024 · 1 comment

Comments

@gdalle
Copy link
Member

gdalle commented Oct 7, 2024

I don't think the tests in https://github.com/JuliaDiff/SparseDiffTools.jl/blob/master/test/test_gpu_ad.jl verify correctness of the Jacobian, it's only about whether or not the code runs. Since #302 breaks GPU tests, it means the code path with the wrong indexing was taken by GPUs, so GPU Jacobians have probably been wrong all along.

@ChrisRackauckas
Copy link
Member

There are SciMLSensitivity/DiffEqFlux downstream tests that would've required its accuracy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants