-
Notifications
You must be signed in to change notification settings - Fork 20
Add converter from WKT2 to PROJSON strings #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
💎 $400 bounty • JuliaEarthSteps to solve:
❗ Important guidelines:
Thank you for contributing to JuliaEarth/GeoIO.jl!
|
/attempt #150 Options |
/attempt #150
|
💡 @onyedikachi-david submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
/attempt #150 Options |
/attempt #150 |
I will chime in and say a few things about the bounty, maybe some advice as well specially regarding the GDAL testing, since i spent last 2 days working through it. It's actually very easy to do a complete parser (and not use regex or hardcoded matching) using tree discovery, but GDAL (in this case Arch GDAL) uses a different numbering system internally, which messes up the whole flow of testing. |
Thank you for sharing @zelosleone. Could you please elaborate on the different numbering system? Our ultimate goal is to completely eliminate the dependency on GDAL. So we would be happy to adjust the tests accordingly if we see there is no point in trying to match GDAL's output. The main concern we have is correctness of the PROJJSON string, and adherence to the schema. |
I didn't exactly test like onyedi, I used manual datas to load up the WKT2 files (since your testing builds were built exactly like this) Sample datas were taken from official sources as well, then used their authority numbers and turns out, Arch GDAL uses a different numbering system. |
If you can share examples of mismatch, that can help us decide the next steps. |
Increasing to /bounty $400. |
/attempt #150 |
I will provide example data and a PR (i spent the full day on this! haha, but all things aside it was a really experimental attempt because of C calls, but my testing shows up-to-date conversion so it was a success. it will be okay even if you guys reject it tbh, though hopefully not. Small PR as well, happy easter!) |
/attempt #150 working on a pure Julia solution |
What do "most" and "relevant" mean here? Is it not necessary to support all EPSG definitions? |
Hi @nsajko , we need to support the EPSG codes currently mapped to CRS types here: |
Issue
The GeoParquet specification does not adhere to OGC WKT-CRS standards, and instead relies on PROJJSON strings.
Therefore, we need to convert from our native
CoordRefSystems.wkt2
strings added in JuliaEarth/CoordRefSystems.jl#245 to the PROJJSON encoding in order to save data in GeoParquet format.Bounty
Our current implementation, which can be found here, relies on external calls to GDAL:
We need to rewrite this function in terms of
CoordRefSystems.wkt2(code)
, parsing the resulting string into a valid PROJJSON.A Julia-native solution that
will get a /bounty $250.
Tips
The text was updated successfully, but these errors were encountered: