From f6f7d64f22cc31e251b038f525ad8a3cfc9e1fdf Mon Sep 17 00:00:00 2001 From: Will Tebbutt Date: Mon, 27 Feb 2023 14:54:15 +0000 Subject: [PATCH 1/3] Loosen tolerance on test --- test/mokernels/independent.jl | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/test/mokernels/independent.jl b/test/mokernels/independent.jl index a1ce1c25a..7fba33d77 100644 --- a/test/mokernels/independent.jl +++ b/test/mokernels/independent.jl @@ -1,8 +1,9 @@ @testset "independent" begin outdim = 3 - x = KernelFunctions.MOInputIsotopicByOutputs([rand(5) for _ in 1:4], outdim) - y = KernelFunctions.MOInputIsotopicByOutputs([rand(5) for _ in 1:4], outdim) - z = KernelFunctions.MOInputIsotopicByOutputs([rand(5) for _ in 1:2], outdim) + rng = StableRNG(123456) + x = KernelFunctions.MOInputIsotopicByOutputs([rand(rng, 5) for _ in 1:4], outdim) + y = KernelFunctions.MOInputIsotopicByOutputs([rand(rng, 5) for _ in 1:4], outdim) + z = KernelFunctions.MOInputIsotopicByOutputs([rand(rng, 5) for _ in 1:2], outdim) xIF = KernelFunctions.MOInputIsotopicByFeatures(x.x, outdim) yIF = KernelFunctions.MOInputIsotopicByFeatures(y.x, outdim) @@ -14,19 +15,22 @@ @test k isa Kernel @test k.kernel isa Kernel - @test kernelmatrix(k, x, y) == kernelmatrix(k, collect(x), collect(y)) + @test isapprox( + kernelmatrix(k, x, y), kernelmatrix(k, collect(x), collect(y)); + rtol=1e-6, + ) ## accuracy KernelFunctions.TestUtils.test_interface(k, x, y, z) KernelFunctions.TestUtils.test_interface(k, xIF, yIF, zIF) # type stability (maybe move to test_interface?) - x2 = MOInput(rand(Float32, 4), 2) + x2 = MOInput(rand(rng, Float32, 4), 2) @test k(x2[1], x2[2]) isa Float32 @test k(x2[1], x2[1]) isa Float32 @test eltype(typeof(kernelmatrix(k, x2))) <: Float32 @test string(k) == "Independent Multi-Output Kernel\n" * - "\tSquared Exponential Kernel (metric = Euclidean(0.0))" + "\tSquared Exponential Kernel (metric = Euclidean(0.0))" end From 4ca6de69c1c2caebfcb788c47e768d59dda6236a Mon Sep 17 00:00:00 2001 From: Will Tebbutt Date: Mon, 27 Feb 2023 14:56:01 +0000 Subject: [PATCH 2/3] Tweak formatting --- test/mokernels/independent.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/mokernels/independent.jl b/test/mokernels/independent.jl index 7fba33d77..2129b150f 100644 --- a/test/mokernels/independent.jl +++ b/test/mokernels/independent.jl @@ -32,5 +32,5 @@ @test string(k) == "Independent Multi-Output Kernel\n" * - "\tSquared Exponential Kernel (metric = Euclidean(0.0))" + "\tSquared Exponential Kernel (metric = Euclidean(0.0))" end From be17c1f76d1b91209bc30aa863333cab757239ce Mon Sep 17 00:00:00 2001 From: Will Tebbutt Date: Mon, 27 Feb 2023 14:59:33 +0000 Subject: [PATCH 3/3] Fix formatting --- test/mokernels/independent.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/mokernels/independent.jl b/test/mokernels/independent.jl index 2129b150f..9c216826f 100644 --- a/test/mokernels/independent.jl +++ b/test/mokernels/independent.jl @@ -16,8 +16,7 @@ @test k.kernel isa Kernel @test isapprox( - kernelmatrix(k, x, y), kernelmatrix(k, collect(x), collect(y)); - rtol=1e-6, + kernelmatrix(k, x, y), kernelmatrix(k, collect(x), collect(y)); rtol=1e-6 ) ## accuracy