[RNTuple] add test files for extension header (#333)

* [RNTuple] add test files for extension header

* more test for bool and fix boolean logic

Author: Moelf

src/RNTuple/fieldcolumn_reading.jl

@@ -93,12 +93,15 @@ _field_output_type(::Type{LeafField{T}}) where {T} = Vector{T}
 function read_field(io, field::LeafField{T}, page_list) where T
     cr = field.columnrecord
     pages = page_list[field.content_col_idx]
-    res = collect(reinterpret(T, read_pagedesc(io, pages, cr)))
     fei = cr.first_ele_idx
-    if !iszero(fei)
-        z = zero(eltype(res))
-        prepend!(res, fill(z, fei))
+    res = if !iszero(fei)
+        z = zero(T)
+        fill(z, fei)
+    else
+        T[]
     end
+
+    append!(res, reinterpret(T, read_pagedesc(io, pages, cr)))
     return res::_field_output_type(field)
 end
 
@@ -110,7 +113,7 @@ function read_field(io, field::LeafField{Bool}, page_list)
 
     # pad to nearest 8*k bytes because each chunk needs to be UInt64
     bytes = read_pagedesc(io, pages, cr)
-    append!(bytes, zeros(eltype(bytes), 8 - rem(total_num_elements, 8)))
+    append!(bytes, zeros(eltype(bytes), (64 - rem(total_num_elements, 64))÷8))
     chunks = reinterpret(UInt64, bytes)
 
     res = BitVector(undef, total_num_elements)

test/rntuple.jl

@@ -227,6 +227,21 @@ end
     @test length(truth_jets_one_event.pt) == 5
 end
 
+@testset "Footer extension header links backfill" begin
+    f1 = UnROOT.samplefile("RNTuple/test_ntuple_extension_columns.root")
+    df = LazyTree(f1, "EventData")
+    pbs = collect(df.var"HLT_AntiKt4EMPFlowJets_subresjesgscIS_ftf_TLAAux::fastDIPS20211215_pb")
+    @test length(pbs) == 40
+    @test findfirst(!isempty, pbs) == 37
+    jets = collect(df.var"HLT_AntiKt4EMPFlowJets_subresjesgscIS_ftf_TLAAux:")
+
+    @test length.(pbs) == length.(getproperty.(jets, :pt))
+
+    # backfilled booleans
+    xTrigDecisionAux = collect(df.var"xTrigDecisionAux:")
+    @test length(xTrigDecisionAux) == length(pbs)
+end
+
 @testset "RNTuple Tables.jl and Arrow integration" begin
     f1 = UnROOT.samplefile("RNTuple/test_ntuple_stl_containers.root")
     rnt = LazyTree(f1, "ntuple")

test/samples/RNTuple/test_ntuple_extension_columns.md

@@ -0,0 +1,14 @@
+1. Checkout an Athena build with ROOT nightly (currently has RNTuple RC2)
+2. Get an ATLAS RAW file
+3. Run reco:
+```bash
+Reco_tf.py \
+  --CA="True" \
+  --maxEvents=40 \
+  --multithreaded="True" \
+  --sharedWriter="True" \
+  --parallelCompression="False" \
+  --inputBSFile="raw.root" \
+  --outputDAOD_TLAFile="daod_tla.root" \
+  --preExec="flags.Output.StorageTechnology.EventData=\"ROOTRNTUPLE\"";
+```