WIP: Fix llvmcall recursion

Author: vchuravy

src/overdub.jl

@@ -316,6 +316,24 @@ function overdub_pass!(reflection::Reflection,
                             end)
     end
 
+    #=== mark all `llvmcall`s as nooverdub ===#
+    # TODO: this only works for: `Intrinsics.llvmcall` and not `Core.Intrinsics.llvmcall`
+    # since there is a getproperty call in the way.
+    # TODO: Need to fix for `istaggingenabled == true`
+    if !iskwfunc && !istaggingenabled
+        insert_statements!(overdubbed_code, overdubbed_codelocs,
+                            (x, i) -> begin
+                                if Base.Meta.isexpr(x, :call) &&
+                                  is_ir_element(x.args[1], GlobalRef(Core.Intrinsics, :llvmcall), overdubbed_code)
+                                    return 1
+                                end
+                                return nothing
+                            end,
+                            (x, i) -> begin
+                                [Expr(:call, Expr(:nooverdub, GlobalRef(Core.Intrinsics, :llvmcall)), x.args[2:end]...)]
+                            end)
+    end
+
     #=== untag all `foreigncall` SSAValue/SlotNumber arguments if tagging is enabled ===#
 
     if istaggingenabled && !iskwfunc

test/misctests.jl

@@ -633,8 +633,12 @@ callback()
 
 println("done (took ", time() - before_time, " seconds)")
 
+#############################################################################################
 # Test overdubbing of a call overload invoke
 
+print("   running CtxCallOverload test...")
+before_time = time()
+
 using LinearAlgebra
 
 struct Dense{F,S,T}
@@ -663,3 +667,38 @@ let d = Dense(3,3)
     data = rand(3)
     Cassette.overdub(CtxCallOverload(), d, data)
 end
+
+println("done (took ", time() - before_time, " seconds)")
+
+#############################################################################################
+
+print("   running LLVMCallCtx test...")
+before_time = time()
+using Cassette
+Cassette.@context LLVMCallCtx
+
+# This overdub does nothing
+@noinline function Cassette.overdub(ctx::LLVMCallCtx, f, args...)
+    if Cassette.canrecurse(ctx, f, args...)
+        Cassette.recurse(ctx, f, args...)
+    else
+        Cassette.fallback(ctx, f, args...)
+    end
+end
+
+import Core.Intrinsics
+function llvm_sin(x::Float64)
+    # Needs fix for Core.Intrinsics.llvmcall
+    Intrinsics.llvmcall(
+        (
+            """declare double @llvm.sin.f64(double)""",
+            """%2 = call double @llvm.sin.f64(double %0)
+               ret double %2"""
+        ),
+        Float64, Tuple{Float64}, x
+    )
+end
+
+Cassette.@overdub LLVMCallCtx() llvm_sin(4.0)
+
+println("done (took ", time() - before_time, " seconds)")