Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Date parsing crash when parsing a negative year (#53981)
Fixes #50328. Originally checked on version 1.10.0 but still relevant in the current version in master Bug: In method Date(str), when given a negative year as an argument (ex: "-2000"), it would output an error while in Date(int) once given a negative year (ex: "-2000") it would work as intended returning "-2000-01-01". Fix: In function tryparsenext_base10 the character '-' wasn't being accounted so i check if it existed in the first iteration of the string and if yes I would multiply the output * -1. Test: Added some tests that verify this specific Fix. --------- Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Viral B. Shah <[email protected]>
- Loading branch information
4366a93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the daily package evaluation, I will reply here when finished:
@nanosoldier
runtests(isdaily = true)
4366a93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.