Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify arch in ci matrix #464

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Don't specify arch in ci matrix #464

merged 1 commit into from
Dec 3, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 3, 2024

Currently, we specify the arch as x64, but the macos tests are run on arm64 platforms. It's perhaps best to leave this implicit so that the correct defaults are used.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (e9d199c) to head (6ae42c6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   89.93%   89.68%   -0.26%     
==========================================
  Files          25       25              
  Lines        3675     3673       -2     
==========================================
- Hits         3305     3294      -11     
- Misses        370      379       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit db91085 into master Dec 3, 2024
18 of 19 checks passed
@jishnub jishnub deleted the jishnub/ci_arch branch December 3, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant