Skip to content
This repository was archived by the owner on Apr 26, 2021. It is now read-only.

Deprecate in favor of GenericLinearAlgebra.jl? #30

Open
simonbyrne opened this issue Mar 26, 2021 · 8 comments
Open

Deprecate in favor of GenericLinearAlgebra.jl? #30

simonbyrne opened this issue Mar 26, 2021 · 8 comments

Comments

@simonbyrne
Copy link
Collaborator

simonbyrne commented Mar 26, 2021

The code in this package was originally a slightly cleaned up version of @andreasnoack's code in GenericLinearAlgebra.jl (which at that point was an unregistered package called LinearAlgebra.jl, predating the stdlib of the same name). I haven't really done much with this package since its creation, other than merging version upgrades and obvious bug fixes (thanks to the contributors!), and GenericLinearAlgebra.jl is now a registered and more complete package. There are also some issues with the packages type piracy causing conflicts (see JuliaLinearAlgebra/GenericLinearAlgebra.jl#71).

Are there any opinions on deprecating this package in favor of GenericLinearAlgebra.jl? The currently registered direct dependencies are:

@simonbyrne
Copy link
Collaborator Author

Actually, it looks like OrdinaryDiffEq.jl no longer depends on this SciML/OrdinaryDiffEq.jl#1356?

@simonbyrne
Copy link
Collaborator Author

Any thoughts @RalphAS @matbesancon?

@simonbyrne
Copy link
Collaborator Author

Seems like the main missing bit of functionality in GenericLinearAlgebra is the full keyword (JuliaLinearAlgebra/GenericLinearAlgebra.jl#20 (comment)) added by @olof3.

@matbesancon
Copy link
Contributor

Agreed to deprecate it for GenericLinearAlgebra

@RalphAS
Copy link
Contributor

RalphAS commented Mar 26, 2021

It has been handy to have a separate SVD for compatibility with GenericSchur. I have recently tried to make the latter compatible with GenericLinearAlgebra; if that effort is successful then I can agree.

@JeffreySarnoff
Copy link

that is sane

@olof3
Copy link
Contributor

olof3 commented Mar 26, 2021

It has been handy to have a separate SVD for compatibility with GenericSchur. I have recently tried to make the latter compatible with GenericLinearAlgebra; if that effort is successful then I can agree.

Wouldn't it be good to merge the GenericSchur functionality into GenericLinearAlgebra as well? Or is that what you are referring to?

@simonbyrne
Copy link
Collaborator Author

Okay, now that GenericLinearAlgebra is at feature parity, I am going to deprecate this package.

simonbyrne added a commit to JuliaMath/DoubleFloats.jl that referenced this issue Mar 30, 2021
Due to type piracy, these packages cause problems with precompilation and don't play nice with GenericLinearAlgebra (see discussion in JuliaLinearAlgebra/GenericLinearAlgebra.jl#71). Additionally, GenericSVD has now been deprecated (JuliaLinearAlgebra/GenericSVD.jl#30).
simonbyrne added a commit to simonbyrne/ArbNumerics.jl that referenced this issue Mar 30, 2021
Due to type piracy, these packages cause problems with precompilation and don't play nice with GenericLinearAlgebra (see discussion in JuliaLinearAlgebra/GenericLinearAlgebra.jl#71). Additionally, GenericSVD has now been deprecated (JuliaLinearAlgebra/GenericSVD.jl#30).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants