Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar indexing of CuArray in lsqr #354

Closed
oscarvanderheide opened this issue Nov 13, 2023 · 1 comment
Closed

Scalar indexing of CuArray in lsqr #354

oscarvanderheide opened this issue Nov 13, 2023 · 1 comment

Comments

@oscarvanderheide
Copy link
Contributor

When I run lsqr on CuArrays, the lines

    for i = 1:n
        isfinite(x[i]) || error("Initial guess for x must be finite")
    end

result in poor performance due to scalar indexing. I replaced this with

  if !(all(isfinite.(x)))
      error("Initial guess for x must be finite")
  end

but before I submit a PR I thought it would be better to file and issue and discuss potential implications of the proposed approach.

@oscarvanderheide oscarvanderheide changed the title Scalar indexing in lsqr Scalar indexing of CuArray in lsqr Nov 13, 2023
@amontoison
Copy link
Member

The implementation of lsqr in Krylov.jl works on GPUs if it can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants