Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding type piracy in kron #86

Open
jishnub opened this issue Oct 19, 2022 · 1 comment
Open

Avoiding type piracy in kron #86

jishnub opened this issue Oct 19, 2022 · 1 comment

Comments

@jishnub
Copy link
Member

jishnub commented Oct 19, 2022

https://github.com/JuliaMatrices/LazyBandedMatrices.jl/blob/d0fa057258960095c074dd9cd09c32f7ca2077d2/src/LazyBandedMatrices.jl#L159-L169

Since this is type-piracy, I wonder if it might not be better to define a kron function inherent to this module instead of overloading the one from LinearAlgebra?
@dlfivefifty
Copy link
Member

It would actually be better to move this kron implementation to BandedMatrices.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlfivefifty @jishnub