minor code polish, use unicode #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 98.83% 98.37% -0.46%
==========================================
Files 8 8
Lines 428 430 +2
==========================================
Hits 423 423
- Misses 5 7 +2
Continue to review full report at Codecov.
|
dkarrasch
changed the title
JeffFessler
reviewed
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57 (whether or not we decide to specialize boolean UniformScaling multiplication).This PR only implements some recommendations from Julia Style Guide. I'll put the possible fix to #57 into a separate PR.