-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider making RecursiveArrayTools and StaticArrays weak dependencies #656
Comments
I will maybe try this next, though for edit: but besides that there is even an interplay between StaticArrays and RecursiveArrayTools (double-ext-necessary) Array is much less work. Will try that tomorrow then and see how much this affects other stuff. Still this might be considered breaking. |
This may indeed be a bit breaking so I'd prefer to have it scheduled for the next breaking release instead of rushing it now. |
I started and noticed it is mainly code-reorganisation, but there might be 2-3 small breaking things
So – I will slowly do this, open a PR, but that should really only be merged when we have more reasons for a breaking change – since this decoupling will also not have such a large effect on loading and such. So I fully agree with your opinion :) |
We can probably close this because RecursiveArrayTools is now a weak dependency and StaticArrays is not worth extracting at the moment? |
Yes. |
It might be a bit counter-intuitive to the current structure, where we have these methods with specific manifolds,
but I think for the package it would be neat if these packages that introduce speedups for certain data types would be weak dependencies.
The text was updated successfully, but these errors were encountered: