Skip to content

Commit be022d6

Browse files
committed
Added comment wrt. CUDA platform expansion wrt. C++ string ABI
1 parent 92fe008 commit be022d6

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

O/ONNXRuntime/build_tarballs.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ version = v"1.10.0"
77

88
# Cf. https://onnxruntime.ai/docs/execution-providers/CUDA-ExecutionProvider.html#requirements
99
# Cf. https://onnxruntime.ai/docs/execution-providers/TensorRT-ExecutionProvider.html#requirements
10-
cuda_tag = "11.3" # No CUDA 10.2, since pre-built x86_64 ONNXRuntime-CUDA binaries are built for CUDA 11
10+
cuda_tag = "11.3" # No CUDA 10.2, since pre-built x86_64 CUDA binaries are built for CUDA 11
1111
cuda_aarch64_tag = "10.2"
1212
cudnn_version = v"8.2.4"
1313
tensorrt_version = v"8.0.1"
@@ -87,7 +87,6 @@ function platform_exclude_filter(p::Platform)
8787
Sys.isfreebsd(p)
8888
end
8989
platforms = supported_platforms(; exclude=platform_exclude_filter)
90-
platforms = expand_cxxstring_abis(platforms; skip=!Sys.islinux)
9190

9291
cuda_platforms = Platform[]
9392
for p in [
@@ -100,6 +99,9 @@ end
10099
push!(platforms, Platform("aarch64", "Linux"; cuda = cuda_aarch64_tag))
101100
push!(cuda_platforms, Platform("aarch64", "Linux"; cuda = cuda_aarch64_tag))
102101

102+
platforms = expand_cxxstring_abis(platforms; skip=!Sys.islinux)
103+
# Not expanding cuda_platforms wrt. cxxstring ABIs, since pre-built x86_64 CUDA binaries are built for cxx03 (and the tensorrt provider for both x86_64 and aarch64 is built for cxx11)
104+
103105
# The products that we will ensure are always built
104106
products = [
105107
LibraryProduct(["libonnxruntime", "onnxruntime"], :libonnxruntime)

0 commit comments

Comments
 (0)