Skip to content

Commit 69fc75f

Browse files
authored
Merge pull request #233 from JuliaReach/schillic/ExplicitImports
Use ExplicitImports in tests
2 parents 3cc6bb4 + 49c2eb7 commit 69fc75f

4 files changed

Lines changed: 29 additions & 7 deletions

File tree

test/Aqua.jl

Lines changed: 0 additions & 6 deletions
This file was deleted.

test/Project.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
[deps]
22
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
3+
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
34
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
45

56
[compat]
67
Aqua = "0.8"
8+
ExplicitImports = "1"
9+
Pkg = "<0.0.1, 1.2"
10+
11+
[extras]
12+
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"

test/quality_assurance.jl

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
using ReachabilityBenchmarks, Test
2+
import Aqua
3+
4+
import Pkg
5+
@static if VERSION >= v"1.6" # TODO make explicit test requirement
6+
Pkg.add("ExplicitImports")
7+
import ExplicitImports
8+
9+
@testset "ExplicitImports tests" begin
10+
@test isnothing(ExplicitImports.check_all_explicit_imports_are_public(ReachabilityBenchmarks))
11+
@test isnothing(ExplicitImports.check_all_explicit_imports_via_owners(ReachabilityBenchmarks))
12+
@test isnothing(ExplicitImports.check_all_qualified_accesses_are_public(ReachabilityBenchmarks))
13+
@test isnothing(ExplicitImports.check_all_qualified_accesses_via_owners(ReachabilityBenchmarks))
14+
@test isnothing(ExplicitImports.check_no_implicit_imports(ReachabilityBenchmarks))
15+
@test isnothing(ExplicitImports.check_no_self_qualified_accesses(ReachabilityBenchmarks))
16+
@test isnothing(ExplicitImports.check_no_stale_explicit_imports(ReachabilityBenchmarks))
17+
end
18+
end
19+
20+
@testset "Aqua tests" begin
21+
Aqua.test_all(ReachabilityBenchmarks)
22+
end

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
using Test, ReachabilityBenchmarks
22

3-
include("Aqua.jl")
3+
include("quality_assurance.jl")

0 commit comments

Comments
 (0)