From 0cf96813f2ec2e2032ca6e8953cbc4194f0df65c Mon Sep 17 00:00:00 2001 From: WalterMadelim <143272683+WalterMadelim@users.noreply.github.com> Date: Thu, 8 May 2025 15:13:16 +0800 Subject: [PATCH 1/2] Update cholmod.jl --- src/solvers/cholmod.jl | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/solvers/cholmod.jl b/src/solvers/cholmod.jl index 7cca3775..d10d8114 100644 --- a/src/solvers/cholmod.jl +++ b/src/solvers/cholmod.jl @@ -1504,8 +1504,8 @@ end Compute the Cholesky (``LL'``) factorization of `A`, reusing the symbolic factorization `F`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/ -[`Hermitian`](@ref) view of a `SparseMatrixCSC`. Note that even if `A` doesn't -have the type tag, it must still be symmetric or Hermitian. +[`Hermitian`](@ref) view of a `SparseMatrixCSC`. Note that if `A` doesn't +have the type tag, itself must be symmetric or Hermitian. See also [`cholesky`](@ref). @@ -1540,8 +1540,8 @@ end Compute the Cholesky factorization of a sparse positive definite matrix `A`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/[`Hermitian`](@ref) -view of a `SparseMatrixCSC`. Note that even if `A` doesn't -have the type tag, it must still be symmetric or Hermitian. +view of a `SparseMatrixCSC`. Note that if `A` doesn't +have the type tag, itself must be symmetric or Hermitian. If `perm` is not given, a fill-reducing permutation is used. `F = cholesky(A)` is most frequently used to solve systems of equations with `F\\b`, but also the methods [`diag`](@ref), [`det`](@ref), and @@ -1671,8 +1671,8 @@ end Compute the ``LDL'`` factorization of `A`, reusing the symbolic factorization `F`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/[`Hermitian`](@ref) -view of a `SparseMatrixCSC`. Note that even if `A` doesn't -have the type tag, it must still be symmetric or Hermitian. +view of a `SparseMatrixCSC`. Note that if `A` doesn't +have the type tag, itself must be symmetric or Hermitian. See also [`ldlt`](@ref). @@ -1713,8 +1713,8 @@ end Compute the ``LDL'`` factorization of a sparse matrix `A`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/[`Hermitian`](@ref) -view of a `SparseMatrixCSC`. Note that even if `A` doesn't -have the type tag, it must still be symmetric or Hermitian. +view of a `SparseMatrixCSC`. Note that if `A` doesn't +have the type tag, itself must be symmetric or Hermitian. A fill-reducing permutation is used. `F = ldlt(A)` is most frequently used to solve systems of equations `A*x = b` with `F\\b`. The returned factorization object `F` also supports the methods [`diag`](@ref), From 33eb31ffd4a2712a44846dd7df470d087f503d8c Mon Sep 17 00:00:00 2001 From: WalterMadelim <143272683+WalterMadelim@users.noreply.github.com> Date: Fri, 9 May 2025 06:52:34 +0800 Subject: [PATCH 2/2] Update cholmod.jl --- src/solvers/cholmod.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/solvers/cholmod.jl b/src/solvers/cholmod.jl index 4ec92f86..cf3df3f1 100644 --- a/src/solvers/cholmod.jl +++ b/src/solvers/cholmod.jl @@ -1505,7 +1505,7 @@ end Compute the Cholesky (``LL'``) factorization of `A`, reusing the symbolic factorization `F`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/ [`Hermitian`](@ref) view of a `SparseMatrixCSC`. Note that if `A` doesn't -have the type tag, itself must be symmetric or Hermitian. +have the type tag, it must itself be symmetric or Hermitian. See also [`cholesky`](@ref). @@ -1541,7 +1541,7 @@ end Compute the Cholesky factorization of a sparse positive definite matrix `A`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/[`Hermitian`](@ref) view of a `SparseMatrixCSC`. Note that if `A` doesn't -have the type tag, itself must be symmetric or Hermitian. +have the type tag, it must itself be symmetric or Hermitian. If `perm` is not given, a fill-reducing permutation is used. `F = cholesky(A)` is most frequently used to solve systems of equations with `F\\b`, but also the methods [`diag`](@ref), [`det`](@ref), and @@ -1675,7 +1675,7 @@ end Compute the ``LDL'`` factorization of `A`, reusing the symbolic factorization `F`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/[`Hermitian`](@ref) view of a `SparseMatrixCSC`. Note that if `A` doesn't -have the type tag, itself must be symmetric or Hermitian. +have the type tag, it must itself be symmetric or Hermitian. See also [`ldlt`](@ref). @@ -1717,7 +1717,7 @@ end Compute the ``LDL'`` factorization of a sparse matrix `A`. `A` must be a [`SparseMatrixCSC`](@ref) or a [`Symmetric`](@ref)/[`Hermitian`](@ref) view of a `SparseMatrixCSC`. Note that if `A` doesn't -have the type tag, itself must be symmetric or Hermitian. +have the type tag, it must itself be symmetric or Hermitian. A fill-reducing permutation is used. `F = ldlt(A)` is most frequently used to solve systems of equations `A*x = b` with `F\\b`. The returned factorization object `F` also supports the methods [`diag`](@ref),