Skip to content

Commit e89b28c

Browse files
committed
Update test_alert_rule_methods.py
1 parent 7633738 commit e89b28c

File tree

1 file changed

+17
-12
lines changed

1 file changed

+17
-12
lines changed

tests/test_alert_rule_methods.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@ def test_update_alert_rule_basic(self, mock_execute_query, mock_get_details):
216216
"pollingInterval": "ONE_DAY",
217217
"tags": ["old-tag"],
218218
"labels": [],
219+
"triggerActionsOnNewEntitiesOnly": True,
220+
"ignorePreviousResults": False,
221+
"notifyOnFailure": True,
222+
"templates": {},
219223
"operations": [{
220224
"__typename": "Operation",
221225
"when": {"type": "FILTER", "condition": ["AND", ["queries.query0.total", ">", 0]]},
@@ -300,24 +304,25 @@ def test_fetch_evaluation_result_download_url(self, mock_execute_query):
300304
assert result == mock_response
301305
mock_execute_query.assert_called_once()
302306

303-
@patch('jupiterone.client.requests.get')
304-
def test_fetch_downloaded_evaluation_results_success(self, mock_get):
307+
def test_fetch_downloaded_evaluation_results_success(self):
305308
"""Test fetch_downloaded_evaluation_results method - success"""
306309
mock_response = Mock()
307310
mock_response.json.return_value = {"data": [{"id": "result-1"}]}
308-
mock_get.return_value = mock_response
311+
312+
with patch.object(self.client, 'session') as mock_session:
313+
mock_session.get.return_value = mock_response
309314

310-
result = self.client.fetch_downloaded_evaluation_results(download_url="https://example.com/download")
315+
result = self.client.fetch_downloaded_evaluation_results(download_url="https://example.com/download")
311316

312-
assert result == {"data": [{"id": "result-1"}]}
313-
mock_get.assert_called_once()
317+
assert result == {"data": [{"id": "result-1"}]}
318+
mock_session.get.assert_called_once_with("https://example.com/download", timeout=60)
314319

315-
@patch('jupiterone.client.requests.get')
316-
def test_fetch_downloaded_evaluation_results_exception(self, mock_get):
320+
def test_fetch_downloaded_evaluation_results_exception(self):
317321
"""Test fetch_downloaded_evaluation_results method - exception"""
318-
mock_get.side_effect = Exception("Network error")
322+
with patch.object(self.client, 'session') as mock_session:
323+
mock_session.get.side_effect = Exception("Network error")
319324

320-
result = self.client.fetch_downloaded_evaluation_results(download_url="https://example.com/download")
325+
result = self.client.fetch_downloaded_evaluation_results(download_url="https://example.com/download")
321326

322-
assert isinstance(result, Exception)
323-
assert str(result) == "Network error"
327+
assert isinstance(result, Exception)
328+
assert str(result) == "Network error"

0 commit comments

Comments
 (0)