Warning when :FOR and :NEEDS use the same "tag" (modName).

Author: Lisias

Source/ModuleManager/ModListGenerator.cs

@@ -123,6 +123,15 @@ public static IEnumerable<string> GenerateModList(IEnumerable<ModAddedByAssembly
                                 mods.Add(dependency);
                                 modListInfo.AppendFormat("  {0}\n", dependency);
                             }
+
+							if (name.Contains(":NEEDS["))
+							{
+								string needs = (name.Substring(name.IndexOf(":NEEDS[") + 7));
+								needs = needs.Substring(0, needs.IndexOf(']'));
+								needs = needs.Replace("!", "").Replace('&', ',').Replace('|', ',');
+								foreach (string s in needs.Split(',')) if (dependency.Equals(s))
+										progress.ForWithInvalidNeedsWarning(dependency, cfgmod);
+							}
                         }
                         catch (ArgumentOutOfRangeException)
                         {

Source/ModuleManager/Progress/IPatchProgress.cs

@@ -26,6 +26,7 @@ public interface IPatchProgress
         EventData<IPass> OnPassStarted { get; }
 
         void Warning(UrlDir.UrlConfig url, string message, params object[] @params);
+		void ForWithInvalidNeedsWarning(string modName, UrlDir.UrlConfig cfgmod);
         void Error(UrlDir.UrlConfig url, string message, params object[] @params);
         void Error(string message, params object[] @params);
         void Exception(Exception exception, string message, params object[] @params);

Source/ModuleManager/Progress/PatchProgress.cs

@@ -130,6 +130,13 @@ public void Warning(UrlDir.UrlConfig url, string message, params object[] @param
             RecordWarningFile(url);
         }
 
+		public void ForWithInvalidNeedsWarning(string tag, UrlDir.UrlConfig url)
+		{
+			Counter.warnings.Increment();
+			logger.Warning("Name {0} shouldn't be used both on :FOR and :NEEDS, as :FOR takes precedence rendering :NEEDS innocuous. Check file {1} node: {2}", tag, url.parent.url, url.type);
+			RecordWarningFile(url);
+		}
+
         public void Error(UrlDir.UrlConfig url, string message, params object[] @params)
         {
             Counter.errors.Increment();

Tests/ForNeedsSameName.cfg

@@ -0,0 +1,15 @@
+@PART[HeatShield0]:FOR[forneedstest]:NEEDS[forneedstest]
+{
+}
+
+@PART[HeatShield0]:FOR[forneedstest]:NEEDS[forneedstest,Squad,Something,Else]
+{
+}
+
+@PART[HeatShield0]:FOR[forneedstest]:NEEDS[!forneedstest&Squad|Something,!Else]
+{
+}
+
+@PART[HeatShield0]:FOR[forneedstest]:NEEDS[Squad|!Something]
+{
+}