use local bounds for drag cubes

Author: dkavolis

FerramAerospaceResearch/FARPartGeometry/GeometryMesh.cs

@@ -57,6 +57,7 @@ public class GeometryMesh
         public readonly Part part;
         private readonly GeometryPartModule module;
         public readonly bool isSkinned;
+        public readonly Bounds meshLocalBounds;
 
         public readonly int invertXYZ;
 
@@ -65,6 +66,7 @@ public class GeometryMesh
 
         public Matrix4x4 thisToVesselMatrix;
         public Matrix4x4 meshLocalToWorld;
+        public Matrix4x4 meshLocalToPart;
         public Bounds bounds;
         public bool valid;
 
@@ -75,6 +77,8 @@ public GeometryMesh(
             GeometryPartModule module
         )
         {
+            this.module = module;
+            part = module.part;
             meshLocalVerts = meshData.vertices;
             triangles = meshData.triangles;
             isSkinned = meshData.isSkinned;
@@ -110,6 +114,7 @@ GeometryPartModule module
 
             gameObjectActiveInHierarchy = meshTransform.gameObject.activeInHierarchy;
 
+            meshLocalBounds = meshBounds;
             bounds = TransformBounds(meshBounds, thisToVesselMatrix);
 
             float tmpTestBounds = bounds.center.x +
@@ -128,9 +133,6 @@ GeometryPartModule module
                 valid = true;
             }
 
-            this.module = module;
-            part = module.part;
-
             if (!module.part.isMirrored)
                 invertXYZ = 1;
             else
@@ -154,6 +156,7 @@ private void UpdateLocalToWorldMatrix()
             meshLocalToWorld = !isSkinned
                                    ? meshTransform.localToWorldMatrix
                                    : Matrix4x4.TRS(meshTransform.position, meshTransform.rotation, Vector3.one);
+            meshLocalToPart = part.transform.worldToLocalMatrix * meshLocalToWorld;
         }
 
         public void TransformBasis(Matrix4x4 newThisToVesselMatrix)
@@ -208,7 +211,7 @@ public void MultithreadTransformBasis(object newThisToVesselMatrixObj)
             }
         }
 
-        private static Bounds TransformBounds(Bounds oldBounds, Matrix4x4 matrix)
+        public static Bounds TransformBounds(Bounds oldBounds, Matrix4x4 matrix)
         {
             Vector3 center = oldBounds.center;
             Vector3 extents = oldBounds.extents;

FerramAerospaceResearch/FARPartGeometry/GeometryPartModule.cs

@@ -69,6 +69,7 @@ public class GeometryPartModule : PartModule, IRescalable<GeometryPartModule>
         public Rigidbody partRigidBody;
 
         public Bounds overallMeshBounds;
+        public Bounds localMeshBounds;
 
         public List<GeometryMesh> meshDataList;
         private List<IGeometryUpdater> geometryUpdaters;
@@ -279,14 +280,14 @@ private void FixedUpdate()
         {
             if (!_ready && _meshesToUpdate == 0)
             {
-                overallMeshBounds = SetBoundsFromMeshes();
+                (localMeshBounds, overallMeshBounds) = SetBoundsFromMeshes();
 
                 // @DRVeyl: Force all cubes to have the same bounds.  Do this any time you recalculate a mesh
                 // (ie when handling animations since this breaks the cubes for anything other than the *current* cube.)
                 foreach (DragCube cube in part.DragCubes.Cubes)
                 {
-                    cube.Size = overallMeshBounds.size;
-                    cube.Center = overallMeshBounds.center;
+                    cube.Size = localMeshBounds.size;
+                    cube.Center = localMeshBounds.center;
                 }
 
                 part.DragCubes.ForceUpdate(true, true);
@@ -367,7 +368,7 @@ private bool IgnoredPredicate(Transform t)
             return true;
         }
 
-        private Bounds SetBoundsFromMeshes()
+        private (Bounds, Bounds) SetBoundsFromMeshes()
         {
             if (meshDataList.Count == 0)
             {
@@ -377,16 +378,22 @@ private Bounds SetBoundsFromMeshes()
             }
 
             Vector3 upper = Vector3.one * float.NegativeInfinity, lower = Vector3.one * float.PositiveInfinity;
+            Vector3 upperLocal = Vector3.one * float.NegativeInfinity, lowerLocal = Vector3.one * float.PositiveInfinity;
             foreach (GeometryMesh geoMesh in meshDataList)
             {
                 if (!geoMesh.valid)
                     continue;
 
                 upper = Vector3.Max(upper, geoMesh.bounds.max);
                 lower = Vector3.Min(lower, geoMesh.bounds.min);
+
+                Bounds meshBounds = GeometryMesh.TransformBounds(geoMesh.meshLocalBounds, geoMesh.meshLocalToPart);
+                upperLocal = Vector3.Max(upperLocal, meshBounds.max);
+                lowerLocal = Vector3.Max(lowerLocal, meshBounds.min);
             }
 
             var overallBounds = new Bounds((upper + lower) * 0.5f, upper - lower);
+            var localBounds = new Bounds((upperLocal + lowerLocal) * 0.5f, upperLocal - lowerLocal);
 
             float tmpTestBounds = overallBounds.center.x +
                                   overallBounds.center.y +
@@ -404,7 +411,7 @@ private Bounds SetBoundsFromMeshes()
                 Valid = true;
             }
 
-            return overallBounds;
+            return (localBounds, overallBounds);
         }
 
         private void GetAnimations()