Congrats on the new release and thanks for implementing phrase boosting via #338 , i'm forking into a new issue it to adress the future of this feature. IIRC you said in one message that you planned this for the 1.11 release so I'm creating this to track the ideas.
Btw: your issue template is making it a bit awkward to create feature requests or ask questions. If you'd rather us use discussions instead I recommend making it explicit in the issue template
First a couple of UI nitpicks:
- UI wise I don't think I saw anywhere recommendations or warning about the number of terms used. Nor on which chars are not allowed unless trying to add it though. Might have looked too quickly though.
- Adding a humongous dictionnary slows the UI upon loading the dictionnary panel. Clearing out/resetting the dictionnary also was unexpectedly slow.
- The import seems to tell the file picker to use .csv only (.txt was not offered in my file picker) but I didn't see details on the format to follow, and just renaming the .txt to .csv worked right away IIRC.
.
Then on the longer game here:
- Your implementation boosts words but can't boost phrases and AFAIK you don't support all the characters that are in parakeet's vocabulary. Afaik both are only a frontend limitation and your decoding engine supports it.
- You don't seem to precompile the dictionary into an optimized trie or something to make it tractable with large lists. On my end the optimized trie + MAES does not kill perfs at all but allows adding an entire field's technical words so I definitely think it's worth it. Especially because it would be opt-in: no one would add a large dict like I do without knowing it would be a bit slower. Also even if it's slower than plain parakeet it's way faster than any model with that kind of technical vocabulary (they're much larger and slower). I have an adaptative min-p gating for choosing tokens and so far I don't think i've really seen extra additions of incorrect words.
Congrats on the new release and thanks for implementing phrase boosting via #338 , i'm forking into a new issue it to adress the future of this feature. IIRC you said in one message that you planned this for the 1.11 release so I'm creating this to track the ideas.
Btw: your issue template is making it a bit awkward to create feature requests or ask questions. If you'd rather us use discussions instead I recommend making it explicit in the issue template
First a couple of UI nitpicks:
.
Then on the longer game here: