Cannot set `Pause` as shortcut on Windows 10

[aphedges]

Murmure version

1.10.1

Operating system

Windows 10

Feature impacted

Shortcuts

Bug description

When I try to set Pause as the shortcut for Toggle to talk on Windows 10, I get the error "Failed to save shortcut", and the shortcut remains unchanged. I get the same error with Scrolllock, but F12 works without any issues.

Steps to reproduce

1. Click on Settings > Shortcuts
2. Click on pencil icon under General > Toggle to talk
3. Press Pause on keyboard
4. See that Pause is now displayed in field
5. Press Enter on keyboard
6. See error "Failed to save shortcut"

Debug logs

Even when setting logging to "Trace", no logs are written around the time of the error.

---

I just found Murmure, and it's very nice to use! This bug isn't a dealbreaker for me, but I'd like to have a single-key shortcut if possible.

[Kieirra]

Thanks for the clear report. The cause was that Pause and ScrollLock were missing from the key mapping on the backend, so the frontend captured the key but the binding got rejected before anything was logged. That is why you saw nothing even in Trace.

Both keys are now supported as shortcuts on Windows and Linux, and this will land in a future release. They will not work on macOS though, since Apple keyboards do not have these keys and there is no stable key code for them.

[aphedges]

Thanks for fixing this so quickly! I can see the fix was committed as ad723f2.

I'll close this issue once I can verify the fix in a release.