System Notifications are not getting triggered on anything

[mdziekon]

Plugin Type

VSCode Extension

App Version

5.7.0

Description

VSCode's extension supposedly has the ability to trigger System notifications (in my case, via notify-send since I'm using Linux) on various events during coding sessions, eg. task completion.

After some initial hurdles caused by running VSCodium in DevContainer, I was able to make it work by creating a notifications proxy, and the "Test Notification" button worked correctly.

However, system notifications do not get triggered at... anything. Be it task completion, error, user approval required... nothing. Nothing triggers system notifications.

Looking at the codebase, I could find only one instance where showSystemNotification event is getting created, and its the onTestNotificationClick handler (webview-ui/src/components/settings/NotificationSettings.tsx:38-47), so that's the "Test Notification" button.

Reproduction steps

1. Make sure System notifications are enabled and tested via "Test Notification" button
2. Start a coding session
3. Wait for entire task completion

What should happen

• System notification gets triggered

What actually happens

• Nothing gets triggered, just the audio notification

Provider

No response

Model

No response

System Information

No response

[mdziekon]

I was able to track down the commit that removed all other places where the showSystemNotification was getting called:
ef7828a
See webview-ui/src/components/chat/ChatView.tsx file changes.

For reference, System Notifications were introduced here, and as far as I can see, they were never refactored into anything else, up until they were removed in the previously mentioned commit:
a692559