V1.0.2 (#87)

* Bugfix: added $commit to Transaction::__invoke
(issue #86)

* Bugfix: added null coalescing to VeloxException throw
(issue #85)

* Bugfix: fixed positional parameter handling
(issue #84)

Author: skylardarkfox

src/Database/Procedures/PreparedStatement.php

@@ -69,8 +69,10 @@ public function addParameterSet(array $paramArray, string $prefix = '') : void {
             if (!is_scalar($value) && !is_null($value)){
                 throw new VeloxException("Value for :".$key." is not a scalar or null.",50);
             }
-            $paramArray[":".$prefix.$key] = $value;
-            unset($paramArray[$key]);
+            if (filter_var($key, FILTER_VALIDATE_INT) === false) {
+                $paramArray[":" . $prefix . $key] = $value;
+                unset($paramArray[$key]);
+            }
         }
         $this->_paramArray[] = $paramArray;
     }

src/Database/Procedures/Query.php

@@ -126,7 +126,7 @@ private function executeStatement(&$stmt, array &$parameters = null) : ResultSet
                         }
                     }
                     else {
-                        throw new VeloxException('PDO Error: SQLSTATE '.$stmt->errorCode().': '.$stmt->errorInfo()[2], $stmt->errorInfo()[1]);
+                        throw new VeloxException('PDO Error: SQLSTATE '.$stmt->errorCode().': '.$stmt->errorInfo()[2], $stmt->errorInfo()[1] ?? 0);
                     }
                 }
                 break;
@@ -276,7 +276,7 @@ public function execute() : bool {
                 }
             }
             else {
-                $placeholders = array_fill(1,$this->getParamCount(),null);
+                $placeholders = array_fill(0,$this->getParamCount(),null);
             }
         }
 
@@ -292,7 +292,7 @@ public function execute() : bool {
                             try {
                                 //PDOStatement::bindParam() is called once for each parameter.
                                 //Equivalent non-PDO parameter binding tends to be done once per statement using an array of parameters, so these calls happen outside the loop.
-                                $stmt->bindParam($key, $placeholders[$key]);
+                                $stmt->bindParam(is_int($key) ? $key+1 : $key, $placeholders[$key]);
                             }
                             catch (\PDOException $ex) {
                                 if (!($this->queryType == Query::QUERY_PROC && str_starts_with($key, ':op_'))) {

src/Database/Procedures/Transaction.php

@@ -31,7 +31,7 @@
  *
  * The Transaction instance is itself callable, and invoking it as a function is a simple alias for calling {@see Transaction::executeAll()}.
  *
- * @version 1.0.0
+ * @version 1.0.2
  * @since 1.0.0-alpha
  * @license https://www.mozilla.org/en-US/MPL/2.0/ Mozilla Public License 2.0
  *
@@ -72,7 +72,7 @@ public function __construct(?Connection &$conn = null) {
      * @ignore
      */
     public function __invoke(bool $commit = false) : void {
-        $this->executeAll();
+        $this->executeAll($commit);
     }
 
     /**