-
Notifications
You must be signed in to change notification settings - Fork 460
Fix Python 3.13 compatibility and dependency issues #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Btw, where are you getting that misaki 0.9.4 isn't a thing? 🤔 https://pypi.org/project/misaki/0.9.4/ Also, packaging is fixed by #24 😅 |
|
ChatGPT what??? While I do think you are write that 3.13 isn't compatible, I did notice that if I look up the error on chatgpt it says the exact same misaki version number error huh. I will let you know if I find any other reason why 3.13 isnt working |
OK that's weird, I probably have a typo when searching in pypi for the package because I remember to find only the 0.7.4 version... anyway I'll fix it together with using the phonemizer-fork package, specially because during testing I have to install espeak, if that package removes this need, is better to use it, and I'll apply this change based on #24. |
I've 3.13 locally and noticed it was failing, I'll add the error to the description for clarity. |
Yes, the |
0.9.4 explicitly requires Python < 3.13, so that's why it was failing to install, if I downgrade to 3.12 the latest commit in main branch works as expected. Version 0.7.4 worked because it was the first version before the restriction on 3.13 was introduced, which was in 0.7.5. |
|
Good example why upper limits should practically never be used. |
Summary
This PR fixes installation issues with Python 3.13 by updating package dependencies and correcting version constraints that were preventing successful installation.
Changes
Python 3.13 Support
Dependency Fixes
Project Maintenance
Testing
Successfully tested with Python 3.13.3:
pip install -r requirements.txt- all dependencies install without errorspip install .- package builds and installs successfullypython -c "import kittentts"- module imports without errorsoutput.wavfile as expected