Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify version detection #324

Open
hbagdi opened this issue Apr 15, 2021 · 0 comments
Open

Simplify version detection #324

hbagdi opened this issue Apr 15, 2021 · 0 comments
Labels
tech-debt

Comments

@hbagdi
Copy link
Member

hbagdi commented Apr 15, 2021

The current code fetches version first using the root path and then using /:workspace/kong if the first one fails. This needs to be refactored and simplified:

  • if deck is run with empty workspace, read version from Root()
  • if deck is run with a non-empty workspace, read version from //kong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify version detection
1 participant
@hbagdi