Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets as a configurable option for pulling kube-webhook-certgen from a private docker repo #1111

Closed
maclermo opened this issue Jan 30, 2025 · 6 comments

Comments

@maclermo
Copy link

Problem Statement

Currently, we are setting the flags -webhook-certificate-config-base-image and -webhook-certificate-config-shell-image.

The reason we have to set these flags is that we are running a Kubernetes cluster behind a firewall that does not allow to pull from public registries for compliance reasons.

The issue we are having is that we cannot pass an imagePullSecrets directive to the Job that is created so that the images get pulled from our private registry.

Proposed Solution

Allow to set an imagePullSecrets for pulling the images

Additional Information

  • Using v1.4
  • Deployed with the latest helm chart /gateway-operator

Acceptance Criteria

  • When supplying value to the flag webhook-certificate-config-image-pull-secret, the value must be added to imagePullSecrets[0].name in the Job's spec.
  • When omitting to supply a value to the flag, no image pull secret must be specified.
@pmalek
Copy link
Member

pmalek commented Jan 30, 2025

In 1.5 we're removing webhook altogether (#1100) as part of #949. This will fix other issues as well.

At that point you won't need any secrets for the job Pods anymore. Given that I'll close this issue.

You can test these changes already via https://hub.docker.com/r/kong/nightly-gateway-operator.

@pmalek pmalek closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
@maclermo
Copy link
Author

maclermo commented Jan 30, 2025

We are currently testing out the operator.

Unfortunately, without the nightly version being in a stable release, we cannot go ahead with buying Enterprise (Kong Konnect and API Gateway with Advanced RateLimiter).

Do you have an ETA for the operator to be released as stable?

We were planning on buying the subscription in march.

Also, should this bump the version to v2 ? Seems to be a breaking change to me...

Thanks.

@pmalek
Copy link
Member

pmalek commented Jan 30, 2025

Do you have an ETA for the operator to be released as stable?

1.5 should be out for March most likely.

Also, should this bump the version to v2 ? Seems to be a breaking change to me...

Flags stay as is (become no-op) so no breakage there. All other validations are covered via CRD CEL validation rules or ValidatingAdmissionPolicy.

@maclermo
Copy link
Author

OK, I think the release timeframe would allow us to proceed with a subscription contract purchase.

I hope that it is planned that setting these no-op flags will output a big warning when launching the controller because of the false sense of concrete action that it might give to the user.

But for now, I know not to set them.

@maclermo
Copy link
Author

Hi, sorry it's me again.

I am now using 1.5 (nightly) and I still get the same behavior.

Is there a document on how to specify the image registry and tag, and image pull secrets for the new 1.5 release?

Thanks.

@pmalek
Copy link
Member

pmalek commented Jan 31, 2025

We've been migrating our nightly builds to a new location recently. If you're using kong/gateway-operator:nightly then that's the old location which is not going to get updated anymore at this stage.

You can find the new nightlies at

#1113 will document that in the README. Thanks for bringing this up 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants