Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta batch error #409

Closed
tonirv68 opened this issue Mar 6, 2025 · 1 comment
Closed

Meta batch error #409

tonirv68 opened this issue Mar 6, 2025 · 1 comment

Comments

@tonirv68
Copy link

tonirv68 commented Mar 6, 2025

First of all thanks for you great job.

When I use meta batch in these recent versions, I receive a syntax error related with the variable frames_per_batch

I think that in load_video_nodes.py
Instead of
assert frames_per_batch % format['frames'][0] == format['frames'][1], \ ...
should be:
assert meta_batch.frames_per_batch % format['frames'][0] == format['frames'][1], \...
AustinMroz added a commit that referenced this issue Mar 6, 2025
@AustinMroz
Fix meta batch with format, remove wan factors
bce08cc 
ComfyUI has added native latent factors for wan, so the ad hoc and
particularly unhelpful factors I made can be pruned.

Fix a missed scoping when checking that meta batch is compatible with a
selected load format. Special thanks to tonirv68.

This is still a bit clunkier than I would like and will likely see
future updates.

Resolves #409
@AustinMroz
Copy link
Collaborator

You are correct. Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AustinMroz @tonirv68