Why does the compose sample use LaunchedEffect for getting service?

[dalewking]

In the example here:https://github.com/Kotlin/kotlinx-rpc/blob/main/samples/ktor-all-platforms-app/composeApp/src/commonMain/kotlin/App.kt#L38

I see lots of code for using LaunchedEffect, but I'm not sure the point of the LaunchedEffect in this case. LaunchedEffect is for launching coroutine code but there is nothing in there that is suspending. And withService never returns null.

Is there some reason that this is not good enough (note I extracted the client into a client variable):

            val service: UserService = remember {
                client.withService()
            }

[Mr3zee]

@dalewking I think it is historical sample, I don't see a reason to use LaunchedEffect now, I'll patch the docs

[dalewking]

That's what I thought. To be clear though using a remember is still important so that you have the same instance across recompositions. Dale King

…

On Mon, Aug 18, 2025, 3:30 AM Alexander Sysoev ***@***.***> wrote: @dalewking <https://github.com/dalewking> I think it is historical sample, I don't see a reason to use LaunchedEffect now, I'll patch the docs — Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACUPTVQ2CPQIGPF4GJ3F7D3OF6IHAVCNFSM6AAAAACED4QFDCVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIMJTG42TKOA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[sylvain-barrepersyn]

But .rpc is suspend, am I wrong ?

[dalewking]

You are wrong. .rpc is not suspending https://github.com/Kotlin/kotlinx-rpc/blob/main/krpc/krpc-ktor/krpc-ktor-client/src/commonMain/kotlin/kotlinx/rpc/krpc/ktor/client/KtorClientDsl.kt#L60

[Mr3zee]

@sylvain-barrepersyn it was but then we changed it to non-suspending

[Mr3zee]

Addressed in #455