Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 2.0.0 support :) #90

Closed
arslanarm opened this issue Jun 3, 2024 · 15 comments · Fixed by #105
Closed

Kotlin 2.0.0 support :) #90

arslanarm opened this issue Jun 3, 2024 · 15 comments · Fixed by #105

Comments

@arslanarm
Copy link

Currently, K2 intellij plugin is in alpha, so it is still isn't "primary" version everyone will migrate to. This issue was created for discussion about supporting Kotlin 2.X.X and Kotlin 1.X.X at the same time, or rather migrate to K2.

My ulterior motive: k2 supoprt when? :)

@xxfast
Copy link

xxfast commented Jun 6, 2024

What exactly is blocking K2 migration?

@Mr3zee
Copy link
Collaborator

Mr3zee commented Jun 6, 2024

Hi!
As I mentioned in this PR, the migration to K2 is going to be performed with replaсing KSP by compiler plugins, so it takes more time

@sgammon
Copy link

sgammon commented Jul 11, 2024

Bump? Maybe it would be good to consider including KSP support just for one more version? Since Kotlin 2.0.0 is stable now

@Mr3zee
Copy link
Collaborator

Mr3zee commented Jul 15, 2024

We decided not to do so, because it would just add more time for the work that will be dropped anyway. Kotlin 2.0 support will come with the next non-bugfix release

@dpopic-etranet
Copy link

Hi!

We started an KMP project and we are using compose for both iOS/android. This almost eliminates all code changes on iOS side. We had to upgraded project to Kotlin 2.0 because we are using multiple modules in our project. In versions lower than 2.0 resources weren't included correctly in build properly.

We need grpc and this library seems like a perfect fit. Is there any estimate when could this be done/released? Any update on this (even inaccurate) would be of great help to us in terms of project planing.

Thx!

@Mr3zee
Copy link
Collaborator

Mr3zee commented Jul 31, 2024

Hi, @dpopic-etranet ! 2.0 may be supported in a couple of weeks.

We need grpc and this library seems like a perfect fit.

I just want to mention, that we don't support gRPC yet

@EricDeng1001
Copy link

I really need this for 2.0.0. Sharing same interface between projects is insanely convenient. But not supporting 2.0.0 makes it impractical to use

@EricDeng1001
Copy link

Hello. When will this merge be released? Can't wait to use it.

@sgammon
Copy link

sgammon commented Aug 17, 2024

Unfortunately we have had to drop kotlinx-rpc for three reasons:

  1. It does not support Kotlin 2.0 at the latest release
  2. It does not provide JS or WASM targeting, precluding easy use in a common source set which ultimately is used by JS or WASM anywhere downstream, even if RPC itself is not used
  3. At the latest Kotlin, KotlinX RPC has a module called "core" which causes issues with all other modules called "core"

@Mr3zee
Copy link
Collaborator

Mr3zee commented Aug 17, 2024

@sgammon can you please explain the issue with the core module? In published artifacts it is called kotlinx-rpc-core

@Mr3zee
Copy link
Collaborator

Mr3zee commented Aug 17, 2024

@sgammon thank you anyway for trying it out and providing feedback. It's sad to hear you have to drop it now, but I hope you may give it a chance when it is more stable.

About the other issues: 2.0 is coming next week, and Wasm is planned right after. JS is already supported for the clients

@sgammon
Copy link

sgammon commented Aug 18, 2024

@Mr3zee as explained here

@EricDeng1001
Copy link

@sgammon thank you anyway for trying it out and providing feedback. It's sad to hear you have to drop it now, but I hope you may give it a chance when it is more stable.

About the other issues: 2.0 is coming next week, and Wasm is planned right after. JS is already supported for the clients

Great!

@dpopic-etranet
Copy link

I see this has been successfully merged! :)

We'll proceed with this for now. In the meantime, do you have any information or an estimate on when gRPC support might be available?

@Mr3zee
Copy link
Collaborator

Mr3zee commented Aug 20, 2024

gRPC is WIP, no estimates now, it is a huge topic
I'll make an issue for it

UPD: #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants