Skip to content

Increase Lincheck version to 3.0 #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Increase Lincheck version to 3.0 #4467

wants to merge 1 commit into from

Conversation

ndkoval
Copy link
Member

@ndkoval ndkoval commented Jul 1, 2025

No description provided.

@ndkoval ndkoval requested a review from dkhalanskyjb July 1, 2025 09:37
@ndkoval ndkoval force-pushed the lincheck-version-3.0 branch from 4687658 to cb01599 Compare July 1, 2025 09:39
dkhalanskyjb
dkhalanskyjb reviewed Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alarming that the CI consistently takes about ~20-30 minutes longer with this change. What could be the reason?

kotlinx-coroutines-core/build.gradle.kts
@@ -252,6 +252,7 @@ kover {

// lincheck has NPE error on `ManagedStrategyStateHolder` class
excludedClasses.addAll("org.jetbrains.kotlinx.lincheck.*")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historical note: https://repo.maven.apache.org/maven2/org/jetbrains/lincheck/lincheck/3.0/lincheck-3.0.jar does contain classes in both org.jetbrains.lincheck and org.jetbrains.kotlinx.lincheck packages, so keeping these exclusions is intentional.

kotlinx-coroutines-core/jvm/test/lincheck/ChannelsLincheckTest.kt
@@ -154,9 +149,6 @@ abstract class ChannelLincheckTestBase(
// @Operation TODO non-linearizable in BufferedChannel
open fun isEmpty() = c.isEmpty

@StateRepresentation
fun state() = (c as? BufferedChannel<*>)?.toStringDebug() ?: c.toString()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, should we also remove toStringDebug() itself? If not, then at least the comment to that function should be updated.

@dkhalanskyjb
Copy link
Collaborator

Also, on my machine, ./gradlew clean check -Pstress=true fails. The following tests have problems:

    Buffered1BroadcastChannelLincheckTest. modelCheckingTest[jvm]
    Buffered1ChannelLincheckTest. modelCheckingTest[jvm]
    Buffered2BroadcastChannelLincheckTest. modelCheckingTest[jvm]
    Buffered2ChannelLincheckTest. modelCheckingTest[jvm]
    ConflatedBroadcastChannelLincheckTest. modelCheckingTest[jvm]
    ConflatedChannelLincheckTest. modelCheckingTest[jvm]
    RendezvousChannelLincheckTest. modelCheckingTest[jvm]
    Semaphore1LincheckTest. modelCheckingTest[jvm]
    Semaphore2LincheckTest. modelCheckingTest[jvm]
    UnlimitedChannelLincheckTest. modelCheckingTest[jvm]

One example of a problem: https://gist.github.com/dkhalanskyjb/528602e1adfdb402b14bcdef11a5ad44

@dkhalanskyjb
Copy link
Collaborator

Sorry, disregard my latest message: the same happens on develop as well. I think I haven't run clean check -Pstress=true for some time, and something may have regressed in my configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndkoval @dkhalanskyjb