Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong HTTP error code when encountering full disk write error #1693

Open
lghds opened this issue Feb 8, 2025 · 1 comment
Open

Wrong HTTP error code when encountering full disk write error #1693

lghds opened this issue Feb 8, 2025 · 1 comment
Assignees
Labels
Milestone

Comments

@lghds
Copy link

lghds commented Feb 8, 2025

Having reported #1691 to the respective client software projects, one of them asked me to point this out to you.

When radicale encounters a full disk while trying to fulfill a request, it responds with 401 Bad Request, while 507 Insufficient Storage would be more appropriate.

Steps to reproduce:

  • 1: Clog the server's disk. This can be artificially achieved for example by querying free disk space with df -h and filling it up with fallocate -l clog_file

  • 2: Try to add, edit or delete entries using a client software to trigger the error.

@pbiering pbiering self-assigned this Feb 9, 2025
@pbiering pbiering added the bug label Feb 9, 2025
@pbiering pbiering added this to the 3.4.2 milestone Feb 9, 2025
@pbiering
Copy link
Collaborator

pbiering commented Feb 9, 2025

make sense, will change the error code next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants