Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12323

Open
mnabideltares opened this issue Apr 26, 2024 · 3 comments · May be fixed by #12997
Open
Assignees
Labels

Comments

@mnabideltares
Copy link
Contributor

mnabideltares commented Apr 26, 2024

Description:

To enhance our computational model for simulating high capacity heat storage systems, we need to implement a pressure "wel/filter" element on top of the existing pressure line element. The pressure filter element will enable us to model the behavior of heat storage under the ground, accounting for their heat exchange processes. This addition is crucial for achieving realistic simulations of heat storage systems and optimizing their performance.

Acceptance Criteria:

  1. Identify the appropriate mathematical formulation for the pressure filter element.
  2. Develop the necessary code changes to integrate the pressure filter element with the existing pressure line element
  3. Add test cases to validate the accuracy and stability of the implemented pressure filter element
  4. Documentation for the test cases
@mnabideltares mnabideltares self-assigned this Apr 26, 2024
@mnabideltares mnabideltares converted this from a draft issue Apr 26, 2024
@mnabideltares mnabideltares moved this from 📋 Sprint Backlog to 👷 In Progress in Kratos Product Backlog May 13, 2024
@rfaasse rfaasse moved this from 👷 In Progress to 📑 Product Backlog in Kratos Product Backlog Jun 10, 2024
@rfaasse
Copy link
Contributor

rfaasse commented Jun 12, 2024

To be looked into before next refinement by @rfaasse

@rfaasse
Copy link
Contributor

rfaasse commented Jul 3, 2024

Had a look into the PR, it is quite limited in scope and size, so should not be too much work to review and adjust. There are some possibilities to include/extend the functions we have in transport_equation_utilities to calculate the biot moduli (also making it easier to unit test this). What is still missing are the integration tests for the line elements (similar to the tests for the thermal well element).

@indigocoral
Copy link
Contributor

@mnabideltares will take a look at this. Related: #12951

@rfaasse rfaasse moved this from 📋 Sprint Backlog to 👷 In Progress in Kratos Product Backlog Dec 19, 2024
@avdg81 avdg81 moved this from 👷 In Progress to 👀 In Review in Kratos Product Backlog Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment