Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install: Add Helm Variables for LLM API Proxy Settings #736

Open
Tracked by #463
elliotxx opened this issue Jan 16, 2025 · 7 comments
Open
Tracked by #463

Install: Add Helm Variables for LLM API Proxy Settings #736

elliotxx opened this issue Jan 16, 2025 · 7 comments
Assignees
Labels
area/installation easy Suitable for beginners or junior developers good first issue Good for newcomers help wanted Extra attention is needed priority/important-soon P1 Must be staffed and worked on either currently,or very soon,ideally in time for the next release
Milestone

Comments

@elliotxx
Copy link
Collaborator

elliotxx commented Jan 16, 2025

What would you like to be added?

Add proxy configuration parameters in Helm chart to support OpenAI and other LLM API calls in internal network environments.

Why is this needed?

Many enterprise users deploy Karpor in internal networks where direct internet access is restricted. This feature will:

  1. Add new Helm chart parameters:
  • httpProxy
  • httpsProxy
  • noProxy
  1. Configure proxy settings for:
  • OpenAI API calls
  • Other LLM service endpoints
  1. Update documentation:
  • Add proxy configuration guide
  • Include example values

This will make it easier to deploy Karpor in enterprise environments where proxy is required for external API calls.

@elliotxx elliotxx added area/installation good first issue Good for newcomers help wanted Extra attention is needed priority/important-soon P1 Must be staffed and worked on either currently,or very soon,ideally in time for the next release labels Jan 16, 2025
@elliotxx elliotxx added this to the v0.7.0 milestone Jan 16, 2025
@elliotxx elliotxx self-assigned this Jan 16, 2025
@github-actions github-actions bot mentioned this issue Jan 16, 2025
37 tasks
@elliotxx elliotxx removed their assignment Jan 20, 2025
@elliotxx elliotxx added the easy Suitable for beginners or junior developers label Feb 2, 2025
@jinjiaKarl
Copy link
Contributor

Hi, I am interested in contributing to this.

@elliotxx
Copy link
Collaborator Author

elliotxx commented Feb 3, 2025

@jinjiaKarl Of course, very welcome! The helm repo is here. If there is any need, ping me at any time.

@jinjiaKarl
Copy link
Contributor

@elliotxx Hi, thanks for the quick response.
I am thinking of adding the following parameters. noProxy means that the proxy is disabled.

Is it ok to proceed or do you have a better idea?

server:
  ai:
   ......
    proxy:
      # -- Enable proxy settings for AI service connections. When false, proxy settings will be ignored.
      enabled: false
      # -- HTTP proxy URL for AI service connections (e.g., "http://proxy.example.com:8080")
      httpProxy: ""
      # -- HTTPS proxy URL for AI service connections (e.g., "https://proxy.example.com:8080")
      httpsProxy: ""

@elliotxx
Copy link
Collaborator Author

elliotxx commented Feb 4, 2025

@jinjiaKarl Hi, I think you’re on the right track with the proxy settings. Just a quick note: noProxy isn't about disabling the proxy; it's a list of addresses that should bypass the proxy. Here’s a quick tweak:

server:
  ai:
    proxy:
      enabled: true
      httpProxy: "http://proxy.example.com:8080"
      httpsProxy: "https://proxy.example.com:8080"
      noProxy: "localhost,127.0.0.1,example.com"

Since the Spring Festival, the reply is later, sorry!

@jinjiaKarl
Copy link
Contributor

jinjiaKarl commented Feb 6, 2025

When I tried to build image, deploy it locally and test the functionality, the UI component failed to build. I suppose some dependencies issue?
Laptop: Darwin 15.1.1, Arm64; Node v23.6.0

> [email protected] build
> GENERATE_SOURCEMAP=false PUBLIC_URL=/public/ craco build

Creating an optimized production build...
Happy[babel]: Version: 5.0.1. Threads: 8 (shared pool)
Happy[babel]: Internal error; unable to serialize options!!!
....
Failed to compile.

isRegExp is not a function

Also, npm install is super slow.

Seems isRegExp is deprecated in node 23, see https://nodejs.org/api/deprecations.html#DEP0055.

Downgrading to node 20 fixed this issue.

@elliotxx
Copy link
Collaborator Author

elliotxx commented Feb 6, 2025

@jinjiaKarl Thanks for the feedback! My local isRegExp is a warning, it won't compile block, my node version is v22, which looks like a compatibility issue for different versions, let we fix it. cc @hai-tian
Running npm install for the first time may be slower, but perhaps you can configure a proxy to solve it?

@elliotxx
Copy link
Collaborator Author

elliotxx commented Feb 7, 2025

Fix #781 by @hai-tian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installation easy Suitable for beginners or junior developers good first issue Good for newcomers help wanted Extra attention is needed priority/important-soon P1 Must be staffed and worked on either currently,or very soon,ideally in time for the next release
Projects
None yet
Development

No branches or pull requests

2 participants