Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Optimize Makefile with Automatic Cleanup and Cross-Platform Builds #776

Open
elliotxx opened this issue Feb 6, 2025 · 0 comments
Labels
chore easy Suitable for beginners or junior developers priority/important-soon P1 Must be staffed and worked on either currently,or very soon,ideally in time for the next release
Milestone

Comments

@elliotxx
Copy link
Collaborator

elliotxx commented Feb 6, 2025

What would you like to be added?

  1. Add logic to automatically delete VERSION file created by make build-xxx commands
  2. Add make build command that automatically selects appropriate build target based on OS (e.g., darwin for Mac)
  3. Add make check command that sequentially executes make lint, make cover, and make build

Except (similar to osp) 👇

make build:

Image

make check:
Image

Why is this needed?

This optimization will improve our build process by:

  1. Preventing accidental commit of VERSION file
  2. Simplifying cross-platform builds
  3. Enforcing code quality checks before builds
  4. Making build process more consistent across environments
@elliotxx elliotxx added chore easy Suitable for beginners or junior developers priority/important-soon P1 Must be staffed and worked on either currently,or very soon,ideally in time for the next release labels Feb 6, 2025
@elliotxx elliotxx added this to the v0.7.0 milestone Feb 6, 2025
@github-actions github-actions bot mentioned this issue Feb 7, 2025
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore easy Suitable for beginners or junior developers priority/important-soon P1 Must be staffed and worked on either currently,or very soon,ideally in time for the next release
Projects
None yet
Development

No branches or pull requests

1 participant