@@ -42,6 +42,7 @@ sanitizers | enable one or more of the sanitizers, cmake: `-DENABLE_SANITIZER_*=
42
42
detector id bindings | enable detector ID python bindings, cmake: ` -DBUILD_DETECTORID_BINDINGS=ON `
43
43
patch cmake | need to do both ` no testing ` and ` force legacy onnx `
44
44
header patch | transitioning to a newer compiler then required a few more headers to be included[ ^ 3 ]
45
+ include lorentz vector | add ` Math/GenVector/LorentzVector.h ` and ` Math/Vector4Dfwd.h ` to inclusions in ` Ecal/IntermediateCluster.h `
45
46
46
47
[ ^ 1 ] : Currently in ldmx-sw, there isn't a command-line option to disable the
47
48
testing so one must comment out the ` build_test() ` line in ` ldmx-sw/CMakeLists.txt ` .
@@ -124,7 +125,7 @@ patches to be included as well.
124
125
It is encouraged to rebase and/or merge ldmx-sw: v4 .3.0 into your branch in
125
126
order for the main CI tests to work now that they use ldmx/dev:5.0.0.
126
127
127
- ### > = v4.3.0
128
+ ### = v4.3.0
128
129
Patches for the newer compiler have been included and so the default build
129
130
configuration can be handled by the new image version.
130
131
Not all of the _ warnings_ from the newer compiler have been patched,
@@ -134,3 +135,26 @@ and runs as expected.
134
135
build config | image version
135
136
---|---
136
137
default | >= v4.0.0
138
+
139
+ ### >= 4.3.1
140
+ One release after getting development to function with ldmx/dev: v5 ,
141
+ I (Tom) accidentally introduced a change that breaks compatibility with ldmx/dev:4.2.2
142
+ which uses an older version of ROOT.
143
+
144
+ The error you see is with using ` XYZTVector ` which is not present in the ` ROOT::Math ` namespace
145
+ without including a couple more headers.
146
+
147
+ ~~~ admonish example title="Example Compile Error Message", collapsible=true
148
+ I've removed the other errors generated by the compiler, mainly focused on how the `centroid` function
149
+ is not defined anymore since its return type is not defined.
150
+ ```
151
+ /home/tom/code/ldmx/ldmx-sw/Ecal/include/Ecal/IntermediateCluster.h:24:21: error: 'XYZTVector' in namespace 'ROOT::Math' does not name a type
152
+ 24 | const ROOT::Math::XYZTVector& centroid() const { return centroid_; }
153
+ | ^~~~~~~~~~
154
+ ```
155
+ ~~~
156
+
157
+ build config | image version
158
+ ---|---
159
+ default | >= v5.0.0
160
+ include lorentz vector | >= v4.0.0
0 commit comments