Move ThemeServiceProvider
and AddonServiceProvider
to CRUD
#5147
Labels
ThemeServiceProvider
and AddonServiceProvider
to CRUD
#5147
Right now all our addons have their own service providers, which extend an AutomaticServiceProvider that lives in each.freaking.package. While that has worked ok so far, because we were unsure whether we want to make changes to them (and we did), we haven't needed to make changes to them in a while. That means they're stable. Different... but stable.
So what I propose we do is create two ServiceProvider classes in CRUD, to hold the logic that is now in the
AutomaticServiceProvider
:ThemeServiceProvider
AddonServiceProvider
Then each package's provider can just extend it.
Notes:
AutomaticServiceProvider
classes are identical; we have to spot the differences before we delete them from their respective packages; and make one provider that caters to all (or override just that one bit they need);ThemeServiceProvider
andAddonServiceProvider
are very similar; so they should share a lot of stuff using traits, or perhaps one extending the other;The text was updated successfully, but these errors were encountered: