Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Core support for dark mode #5201

Open
tabacitu opened this issue Jul 10, 2023 · 0 comments
Open

[Feature Request] Core support for dark mode #5201

tabacitu opened this issue Jul 10, 2023 · 0 comments

Comments

@tabacitu
Copy link
Member

Feature Request

What's the feature you think Backpack should have?

In PRs like Laravel-Backpack/theme-tabler#101 we add some CSS for dark mode. But it's tied to that particular theme, since we use the colors of that theme.

We should have dark mode support in CRUD itself, in common.css. Then each theme that implements dark mode would have dark mode, out-of-the-box. If they need to customize some colors? Fine, they only override those with !important.

Have you already implemented a prototype solution, for your own project?

No I haven't yet. We can do this when we create theme-bootstrap. That theme is super basic, but it does have dark mode. And if that one can use the core dark mode, all themes can use core dark mode.

Do you see this as a core feature or an add-on?

Core feature. Should do. 6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant