modifyField() does not call the defined macros in the modifications

[dimer47]

Bug report

What I did

By using setFromDb() and modifying the type of a field to upload with the modifyField function the form does not apply the enctype.

What I expected to happen

The modifyField method should add the enctype to the form if it is an upload, upload_multiples, image, ... type.

What happened

Currently, the form does not send the file in POST request.

What I've already tried to fix it

If we rewrite the field with CRUD::field instead of modifying it with CRUD::modifyField it works and the enctype is defined

Is it a bug in the latest version of Backpack?

This is indeed the latest version of Backpack v6 and I confirm after running ``composer update backpack/crud``` the bug is still there.

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

BACKPACK PACKAGE VERSIONS:

backpack/basset: 1.2.1
backpack/crud: 6.2.4
backpack/devtools: 3.0.0
backpack/editable-columns: 3.0.2
backpack/generators: v4.0.2
backpack/logmanager: v5.0.1
backpack/pro: 2.0.16
backpack/settings: 3.1.0
backpack/theme-tabler: 1.1.1

The code:

    protected function setupCreateOperation()
    {
        CRUD::setValidation(AccountDocumentRequest::class);
        CRUD::setFromDb();

        // This not add enctype on form 
//        CRUD::modifyField('path', [
//            'type' => 'upload',
//            'withFiles' => true,
//            'tab' => trans('admin/account_address.tabs.general')
//        ]);

        // Redeclaration of field add enctype on form
        CRUD::field([
            'name'=>'path',
            'type' => 'upload',
            'withFiles' => true,
            'tab' => trans('admin/account_address.tabs.general')
        ]);
    }

[welcome]

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

• Bug Reports, Feature Requests - Github Issues (here);
• Quick help (How do I do X) - Gitter Chatroom;
• Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
• Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

[dimer47]

The Backpack\CRUD\app\Library\CrudPanel\Traits\Fields@hasUploadFields check that the field has the upload attribute as true value. If we add it in the modifyField the enctype is added well. I think that it is related to the registered attribute macros function.

What do you think ?

[pxpm]

Hey @dimer47 thanks for the report and the additional information.

I think I got the issue here. The upload => true was a requirement since forever, even before the Uploaders were a thing.

I am not sure about the real intent of it, I am guessing that by the time it was added (very long time ago), was to don't rely on the field types to add the enc-type.

Behind the scenes the Uploaders add this automatically in the field for you.

The Uploader macro is activated with withFiles attribute or method, when addField() or field() are called.
When you do setFromDb, the addField() method generated from your db columns will not have the macro.

The macros should not be ran on field modifications, they should only run when explicitly defined in the addField, or via macro method on the field instance.

Your scenario would work just fine if you do:

CRUD::setFromDb();
CRUD::field('path')->withFiles();

Let me know if it worked for you.

Cheers

[dimer47]

Hey pxpm 👋🏻

Thanks for your return,

I confirm that by doing CRUD::setFromDb(); and CRUD::field('path')->withFiles(); this works perfectly 👍. The enctype is correctly added to form.
Do you think it would be possible to add the macro in the modifyField method to prevent this bug?

Cheers

[pxpm]

Maybe I can work around it by checking if the field don't contain the macro in the previous attributes, only in the ones provided by modifyField(), and in that case, run the macro.

It may work non-BC like that. I will investigate that possibility. I don't think at the moment we have a way to run a specific macro on the field, either run all field macros or specifically call the ->macro() to run it.

I can't prioritize this rigth now, but I will keep this open so I don't forget.

Thanks again for the report 🙏

[dimer47]

Thank you @pxpm for your feedback and your help.
Even if this problem is not corrected, I think it is a good idea to leave the issue open to help developers who notice the same problem.

Thanks again @pxpm